vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 12:20:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Use assertSame() in some newly introduced tests.

Browse Source 
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [48937], [48939], [48940], [48944].

See #38266.

git-svn-id: https://develop.svn.wordpress.org/trunk@49547 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2020-11-09 15:43:14 +00:00
parent 2e01c76841
commit 4eee0d2fb7
12 changed files with 106 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/auth.php
+12 -12
View File
@@ -451,8 +451,8 @@ class Tests_Auth extends WP_UnitTestCase {
$_SERVER['PHP_AUTH_USER'] = 'http_auth_login';
$_SERVER['PHP_AUTH_PW'] = 'http_auth_pass';
$this->assertEquals(
0,
$this->assertSame(
null,
wp_validate_application_password( null ),
'Regular user account password should not be allowed for API authentication'
);
@@ -460,7 +460,7 @@ class Tests_Auth extends WP_UnitTestCase {
// Not try with an App password instead.
$_SERVER['PHP_AUTH_PW'] = $user_app_password;
$this->assertEquals(
$this->assertSame(
$user_id,
wp_validate_application_password( null ),
'Application passwords should be allowed for API authentication'
@@ -491,7 +491,7 @@ class Tests_Auth extends WP_UnitTestCase {
$error = wp_authenticate_application_password( null, 'idonotexist', 'password' );
$this->assertWPError( $error );
$this->assertEquals( 'invalid_username', $error->get_error_code() );
$this->assertSame( 'invalid_username', $error->get_error_code() );
}
/**
@@ -502,7 +502,7 @@ class Tests_Auth extends WP_UnitTestCase {
$error = wp_authenticate_application_password( null, 'idonotexist@example.org', 'password' );
$this->assertWPError( $error );
$this->assertEquals( 'invalid_email', $error->get_error_code() );
$this->assertSame( 'invalid_email', $error->get_error_code() );
}
/**
@@ -514,7 +514,7 @@ class Tests_Auth extends WP_UnitTestCase {
$error = wp_authenticate_application_password( null, self::$_user->user_login, 'password' );
$this->assertWPError( $error );
$this->assertEquals( 'application_passwords_disabled', $error->get_error_code() );
$this->assertSame( 'application_passwords_disabled', $error->get_error_code() );
}
/**
@@ -527,7 +527,7 @@ class Tests_Auth extends WP_UnitTestCase {
$error = wp_authenticate_application_password( null, self::$_user->user_login, 'password' );
$this->assertWPError( $error );
$this->assertEquals( 'application_passwords_disabled', $error->get_error_code() );
$this->assertSame( 'application_passwords_disabled', $error->get_error_code() );
}
/**
@@ -539,7 +539,7 @@ class Tests_Auth extends WP_UnitTestCase {
$error = wp_authenticate_application_password( null, self::$_user->user_login, 'password' );
$this->assertWPError( $error );
$this->assertEquals( 'incorrect_password', $error->get_error_code() );
$this->assertSame( 'incorrect_password', $error->get_error_code() );
}
/**
@@ -560,7 +560,7 @@ class Tests_Auth extends WP_UnitTestCase {
$error = wp_authenticate_application_password( null, self::$_user->user_login, $password );
$this->assertWPError( $error );
$this->assertEquals( 'my_code', $error->get_error_code() );
$this->assertSame( 'my_code', $error->get_error_code() );
}
/**
@@ -574,7 +574,7 @@ class Tests_Auth extends WP_UnitTestCase {
$user = wp_authenticate_application_password( null, self::$_user->user_login, $password );
$this->assertInstanceOf( WP_User::class, $user );
$this->assertEquals( self::$user_id, $user->ID );
$this->assertSame( self::$user_id, $user->ID );
}
/**
@@ -588,7 +588,7 @@ class Tests_Auth extends WP_UnitTestCase {
$user = wp_authenticate_application_password( null, self::$_user->user_email, $password );
$this->assertInstanceOf( WP_User::class, $user );
$this->assertEquals( self::$user_id, $user->ID );
$this->assertSame( self::$user_id, $user->ID );
}
/**
@@ -602,6 +602,6 @@ class Tests_Auth extends WP_UnitTestCase {
$user = wp_authenticate_application_password( null, self::$_user->user_email, WP_Application_Passwords::chunk_password( $password ) );
$this->assertInstanceOf( WP_User::class, $user );
$this->assertEquals( self::$user_id, $user->ID );
$this->assertSame( self::$user_id, $user->ID );
}
}