From 4f2ce0716cf1ac0b87926fab29de189708205967 Mon Sep 17 00:00:00 2001 From: Joe Dolson Date: Sun, 7 Nov 2021 22:08:55 +0000 Subject: [PATCH] Editor: Update structure of title element for editing. Re-format the title element for post editing to follow general scheme for WordPress admin screens. Props SergeyBiryukov. Fixes #52314. git-svn-id: https://develop.svn.wordpress.org/trunk@52030 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/admin-header.php | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/wp-admin/admin-header.php b/src/wp-admin/admin-header.php index 767276b974..9106c63a03 100644 --- a/src/wp-admin/admin-header.php +++ b/src/wp-admin/admin-header.php @@ -49,8 +49,23 @@ if ( $admin_title === $title ) { /* translators: Admin screen title. %s: Admin screen name. */ $admin_title = sprintf( __( '%s — WordPress' ), $title ); } else { + $screen_title = $title; + + if ( 'post' === $current_screen->base && 'add' !== $current_screen->action ) { + $post_title = get_the_title(); + if ( ! empty( $post_title ) ) { + $post_type_obj = get_post_type_object( $typenow ); + $screen_title = sprintf( + /* translators: Editor admin screen title. 1: "Edit item" text for the post type, 2: Post title. */ + __( '%1$s “%2$s”' ), + $post_type_obj->labels->edit_item, + $post_title + ); + } + } + /* translators: Admin screen title. 1: Admin screen name, 2: Network or site name. */ - $admin_title = sprintf( __( '%1$s ‹ %2$s — WordPress' ), $title, $admin_title ); + $admin_title = sprintf( __( '%1$s ‹ %2$s — WordPress' ), $screen_title, $admin_title ); } if ( wp_is_recovery_mode() ) { @@ -58,15 +73,6 @@ if ( wp_is_recovery_mode() ) { $admin_title = sprintf( __( 'Recovery Mode — %s' ), $admin_title ); } -if ( 'post' === $current_screen->base && 'add' !== $current_screen->action ) { - $post_title = get_the_title(); - if ( ! empty( $post_title ) ) { - $obj = get_post_type_object( $typenow ); - /* translators: Editor admin screen title. 1: "Edit item" text for the post type, 2: Post title. */ - $admin_title = sprintf( __( '%1$s “%2$s”' ), $obj->labels->edit_item, $post_title ); - } -} - /** * Filters the title tag content for an admin page. *