From 5001efad74667ba9bf5b4d0d039112296ccbf2f0 Mon Sep 17 00:00:00 2001 From: Jake Spurlock Date: Tue, 8 Jun 2021 22:20:42 +0000 Subject: [PATCH] Administration: Escape the values of data-colname. Adds a `esc_attr` wrapper to `strip_all_tags`. See [33016]. Fixes #40401. Props rellect, SergeyBiryukov, hareesh-pillai, audrasjb. git-svn-id: https://develop.svn.wordpress.org/trunk@51115 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-list-table.php | 4 ++-- src/wp-admin/includes/class-wp-users-list-table.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/wp-admin/includes/class-wp-list-table.php b/src/wp-admin/includes/class-wp-list-table.php index 8169a4fcbc..535f5d5f81 100644 --- a/src/wp-admin/includes/class-wp-list-table.php +++ b/src/wp-admin/includes/class-wp-list-table.php @@ -1425,8 +1425,8 @@ class WP_List_Table { } // Comments column uses HTML in the display name with screen reader text. - // Instead of using esc_attr(), we strip tags to get closer to a user-friendly string. - $data = 'data-colname="' . wp_strip_all_tags( $column_display_name ) . '"'; + // Strip tags to get closer to a user-friendly string. + $data = 'data-colname="' . esc_attr( wp_strip_all_tags( $column_display_name ) ) . '"'; $attributes = "class='$classes' $data"; diff --git a/src/wp-admin/includes/class-wp-users-list-table.php b/src/wp-admin/includes/class-wp-users-list-table.php index 2ab7e9f725..a0a989498c 100644 --- a/src/wp-admin/includes/class-wp-users-list-table.php +++ b/src/wp-admin/includes/class-wp-users-list-table.php @@ -531,7 +531,7 @@ class WP_Users_List_Table extends WP_List_Table { $classes .= ' hidden'; } - $data = 'data-colname="' . wp_strip_all_tags( $column_display_name ) . '"'; + $data = 'data-colname="' . esc_attr( wp_strip_all_tags( $column_display_name ) ) . '"'; $attributes = "class='$classes' $data";