From 50224510ecc7f7f32e28ce70ec1d36754b80f3cc Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 2 Sep 2015 18:14:14 +0000 Subject: [PATCH] Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/edit.php`. props ericlewis, kraftbj, lukecarbis, mrmist. fixes #33671. see #14530. git-svn-id: https://develop.svn.wordpress.org/trunk@33861 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/edit.php | 9 +++++++-- src/wp-includes/class-wp-xmlrpc-server.php | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/wp-admin/edit.php b/src/wp-admin/edit.php index c9ef3b57cd..782b61dc42 100644 --- a/src/wp-admin/edit.php +++ b/src/wp-admin/edit.php @@ -30,8 +30,13 @@ $post_type_object = get_post_type_object( $post_type ); if ( ! $post_type_object ) wp_die( __( 'Invalid post type' ) ); -if ( ! current_user_can( $post_type_object->cap->edit_posts ) ) - wp_die( __( 'Cheatin’ uh?' ), 403 ); +if ( ! current_user_can( $post_type_object->cap->edit_posts ) ) { + wp_die( + '

' . __( 'Cheatin’ uh?' ) . '

' . + '

' . __( 'You are not allowed to edit posts in this post type.' ) . '

', + 403 + ); +} $wp_list_table = _get_list_table('WP_Posts_List_Table'); $pagenum = $wp_list_table->get_pagenum(); diff --git a/src/wp-includes/class-wp-xmlrpc-server.php b/src/wp-includes/class-wp-xmlrpc-server.php index 1c3a93a265..7108ff0a7b 100644 --- a/src/wp-includes/class-wp-xmlrpc-server.php +++ b/src/wp-includes/class-wp-xmlrpc-server.php @@ -1733,7 +1733,7 @@ class wp_xmlrpc_server extends IXR_Server { } if ( ! current_user_can( $post_type->cap->edit_posts ) ) - return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit posts in this post type' )); + return new IXR_Error( 401, __( 'You are not allowed to edit posts in this post type.' )); $query['post_type'] = $post_type->name;