From 515d3fe69fab163a68d4610715c036d100a9e53f Mon Sep 17 00:00:00 2001 From: Andrew Ozz Date: Thu, 12 Jan 2023 23:23:01 +0000 Subject: [PATCH] Menus: Compare `$menu_item->ID` and `$menu_item->menu_item_parent` as strings and avoid moidifying them. Plugins may change the ID to a string. Props Chouby, peterwilsoncc, Chrystl, manooweb, azaozz. Fixes #57169. git-svn-id: https://develop.svn.wordpress.org/trunk@55059 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/nav-menu-template.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/nav-menu-template.php b/src/wp-includes/nav-menu-template.php index 135d35e130..50ed2d481e 100644 --- a/src/wp-includes/nav-menu-template.php +++ b/src/wp-includes/nav-menu-template.php @@ -198,8 +198,12 @@ function wp_nav_menu( $args = array() ) { $sorted_menu_items = array(); $menu_items_with_children = array(); foreach ( (array) $menu_items as $menu_item ) { - // Fix invalid `menu_item_parent`. See: https://core.trac.wordpress.org/ticket/56926. - if ( (int) $menu_item->ID === (int) $menu_item->menu_item_parent ) { + /* + * Fix invalid `menu_item_parent`. See: https://core.trac.wordpress.org/ticket/56926. + * Compare as strings. Plugins may change the ID to string. + * To avoid modifying the object, use `strval()` rather than casting to (string). + */ + if ( strval( $menu_item->ID ) === strval( $menu_item->menu_item_parent ) ) { $menu_item->menu_item_parent = 0; }