From 55b1dd34110045c10e1ea2602171b89db782b19c Mon Sep 17 00:00:00 2001 From: "Dominik Schilling (ocean90)" Date: Wed, 29 Jul 2015 21:29:54 +0000 Subject: [PATCH] Nav menus: Make the selector for the edit menu item link more specific. Prevents clashing with other elements which have the same class. fixes #33129. git-svn-id: https://develop.svn.wordpress.org/trunk@33502 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/js/nav-menu.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/wp-admin/js/nav-menu.js b/src/wp-admin/js/nav-menu.js index b8bae1e747..07b2c37512 100644 --- a/src/wp-admin/js/nav-menu.js +++ b/src/wp-admin/js/nav-menu.js @@ -390,11 +390,11 @@ var wpNavMenu; // Refresh the accessibility when the user comes close to the item in any way menu.on( 'mouseenter.refreshAccessibility focus.refreshAccessibility touchstart.refreshAccessibility' , '.menu-item' , function(){ - api.refreshAdvancedAccessibilityOfItem( $( this ).find( '.item-edit' ) ); + api.refreshAdvancedAccessibilityOfItem( $( this ).find( 'a.item-edit' ) ); } ); // We have to update on click as well because we might hover first, change the item, and then click. - menu.on( 'click', '.item-edit', function() { + menu.on( 'click', 'a.item-edit', function() { api.refreshAdvancedAccessibilityOfItem( $( this ) ); } ); @@ -511,16 +511,16 @@ var wpNavMenu; $( '.menu-item-settings .field-move a' ).hide(); // Mark all menu items as unprocessed - $( '.item-edit' ).data( 'needs_accessibility_refresh', true ); + $( 'a.item-edit' ).data( 'needs_accessibility_refresh', true ); // All open items have to be refreshed or they will show no links - $( '.menu-item-edit-active .item-edit' ).each( function() { + $( '.menu-item-edit-active a.item-edit' ).each( function() { api.refreshAdvancedAccessibilityOfItem( this ); } ); }, refreshKeyboardAccessibility : function() { - $( '.item-edit' ).off( 'focus' ).on( 'focus', function(){ + $( 'a.item-edit' ).off( 'focus' ).on( 'focus', function(){ $(this).off( 'keydown' ).on( 'keydown', function(e){ var arrows,