From 5600ca6bf4d2dd6fa4056f316dcbd01d4efaaf1c Mon Sep 17 00:00:00 2001
From: Weston Ruter <westonruter@git.wordpress.org>
Date: Thu, 21 Jan 2016 06:07:45 +0000
Subject: [PATCH] Customizer: Fix `click.preview` event handler for jump links
 and shift+clicks in preview.

* Prevent following jump links (starting with `#`), but instead scroll that element into view.
* Prevent following links clicked in the Customizer if shift key is pressed when clicking; this fixes an issue when trying to shift-click on a widget or nav menu item (#32681) to just focus on the control in the Customizer.

Fixes #26005.


git-svn-id: https://develop.svn.wordpress.org/trunk@36371 602fd350-edb4-49c9-b593-d223f7449a82
---
 src/wp-includes/js/customize-preview.js | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/src/wp-includes/js/customize-preview.js b/src/wp-includes/js/customize-preview.js
index cfda0edf98..4bf625eb50 100644
--- a/src/wp-includes/js/customize-preview.js
+++ b/src/wp-includes/js/customize-preview.js
@@ -33,7 +33,8 @@
 	 */
 	api.Preview = api.Messenger.extend({
 		/**
-		 * @param {string} url The URL of preview frame
+		 * @param {object} params  - Parameters to configure the messenger.
+		 * @param {object} options - Extend any instance parameter or method with this object.
 		 */
 		initialize: function( params, options ) {
 			var self = this;
@@ -42,9 +43,27 @@
 
 			this.body = $( document.body );
 			this.body.on( 'click.preview', 'a', function( event ) {
+				var link, isInternalJumpLink;
+				link = $( this );
+				isInternalJumpLink = ( '#' === link.attr( 'href' ).substr( 0, 1 ) );
 				event.preventDefault();
+
+				if ( isInternalJumpLink && '#' !== link.attr( 'href' ) ) {
+					$( link.attr( 'href' ) ).each( function() {
+						this.scrollIntoView();
+					} );
+				}
+
+				/*
+				 * Note the shift key is checked so shift+click on widgets or
+				 * nav menu items can just result on focusing on the corresponding
+				 * control instead of also navigating to the URL linked to.
+				 */
+				if ( event.shiftKey || isInternalJumpLink ) {
+					return;
+				}
 				self.send( 'scroll', 0 );
-				self.send( 'url', $(this).prop('href') );
+				self.send( 'url', link.prop( 'href' ) );
 			});
 
 			// You cannot submit forms.