From 590d18844b54188e24b3cccb98e369a500f488c9 Mon Sep 17 00:00:00 2001 From: Andrew Ozz Date: Tue, 17 Jul 2018 14:37:21 +0000 Subject: [PATCH] Customize: Do not attempt to count uncountable value. Props dlh. Fixes #44104. git-svn-id: https://develop.svn.wordpress.org/trunk@43480 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-wp-customize-nav-menus.php | 2 +- tests/phpunit/tests/customize/nav-menus.php | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wp-includes/class-wp-customize-nav-menus.php b/src/wp-includes/class-wp-customize-nav-menus.php index 1a55fa6ce2..d2a346d5b0 100644 --- a/src/wp-includes/class-wp-customize-nav-menus.php +++ b/src/wp-includes/class-wp-customize-nav-menus.php @@ -324,7 +324,7 @@ final class WP_Customize_Nav_Menus { // Prepend list of posts with nav_menus_created_posts search results on first page. $nav_menus_created_posts_setting = $this->manager->get_setting( 'nav_menus_created_posts' ); - if ( 1 === $args['pagenum'] && $nav_menus_created_posts_setting && count( $nav_menus_created_posts_setting ) > 0 ) { + if ( 1 === $args['pagenum'] && $nav_menus_created_posts_setting && count( $nav_menus_created_posts_setting->value() ) > 0 ) { $stub_post_query = new WP_Query( array_merge( $query, diff --git a/tests/phpunit/tests/customize/nav-menus.php b/tests/phpunit/tests/customize/nav-menus.php index e37b94b09f..a5ebfc92f7 100644 --- a/tests/phpunit/tests/customize/nav-menus.php +++ b/tests/phpunit/tests/customize/nav-menus.php @@ -297,6 +297,7 @@ class Test_WP_Customize_Nav_Menus extends WP_UnitTestCase { */ function test_search_available_items_query() { $menus = new WP_Customize_Nav_Menus( $this->wp_customize ); + do_action( 'customize_register', $this->wp_customize ); // Create posts. $post_ids = array();