From 5cabf6737e942fcca1de11fffbe997c3f4732ad7 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Thu, 6 Oct 2022 15:25:47 +0000 Subject: [PATCH] Themes: Replace `array_map()` usage in `WP_Theme_JSON::get_default_slugs()`. When loading a page on the frontend using Xdebug & Webgrind, with the Twenty Twenty-Three theme and no plugins activated, the biggest performance bottleneck currently (on the PHP side) is `WP_Theme_JSON::merge()`. Analysing the data a bit more, it became evident that `WP_Theme_JSON::get_default_slugs()` is the part of that method which takes most of the resources and time. Further analysis of the method revealed that `array_map()` was the call that slowed it down. This commit replaces the `array_map()` call with a simple `foreach` loop, improving page load speed significantly. Follow-up to [52275], [52364]. Props aristath. Fixes #56745. git-svn-id: https://develop.svn.wordpress.org/trunk@54398 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-wp-theme-json.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/wp-includes/class-wp-theme-json.php b/src/wp-includes/class-wp-theme-json.php index 1774c5ef6f..40262661e4 100644 --- a/src/wp-includes/class-wp-theme-json.php +++ b/src/wp-includes/class-wp-theme-json.php @@ -2422,12 +2422,12 @@ class WP_Theme_JSON { } $slugs_for_preset = array(); - $slugs_for_preset = array_map( - static function( $value ) { - return isset( $value['slug'] ) ? $value['slug'] : null; - }, - $preset - ); + foreach ( $preset as $item ) { + if ( isset( $item['slug'] ) ) { + $slugs_for_preset[] = $item['slug']; + } + } + _wp_array_set( $slugs, $metadata['path'], $slugs_for_preset ); }