From 62d0303bb19ce0fe4bff4eb9af494b2f6e0c79d4 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Tue, 17 Nov 2020 16:46:30 +0000 Subject: [PATCH] Plugins: Make sure the HTML ID attributes for plugin checkboxes are unique. Follow-up to [48374]. Props helen, sabernhardt, kishanjasani, mukesh27, hareesh-pillai. Fixes #51256. git-svn-id: https://develop.svn.wordpress.org/trunk@49631 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-plugins-list-table.php | 2 +- src/wp-admin/update-core.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-admin/includes/class-wp-plugins-list-table.php b/src/wp-admin/includes/class-wp-plugins-list-table.php index 80359b6f15..b8af207da0 100644 --- a/src/wp-admin/includes/class-wp-plugins-list-table.php +++ b/src/wp-admin/includes/class-wp-plugins-list-table.php @@ -948,7 +948,7 @@ class WP_Plugins_List_Table extends WP_List_Table { $requires_php = isset( $plugin_data['requires_php'] ) ? $plugin_data['requires_php'] : null; $compatible_php = is_php_version_compatible( $requires_php ); $class = $is_active ? 'active' : 'inactive'; - $checkbox_id = 'checkbox_' . md5( $plugin_data['Name'] ); + $checkbox_id = 'checkbox_' . md5( $plugin_file ); if ( $restrict_network_active || $restrict_network_only || in_array( $status, array( 'mustuse', 'dropins' ), true ) || ! $compatible_php ) { $checkbox = ''; diff --git a/src/wp-admin/update-core.php b/src/wp-admin/update-core.php index 5a4a8d369f..9068fedc78 100644 --- a/src/wp-admin/update-core.php +++ b/src/wp-admin/update-core.php @@ -545,7 +545,7 @@ function list_plugin_updates() { sprintf( __( 'View version %s details.' ), $plugin_data->update->new_version ) ); - $checkbox_id = 'checkbox_' . md5( $plugin_data->Name ); + $checkbox_id = 'checkbox_' . md5( $plugin_file ); ?>