From 69c449963e7bf427106085884e82aacfd7843e43 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Mon, 9 Mar 2015 19:43:49 +0000 Subject: [PATCH] Replace flagrant instances of `.html('')` with `.empty()`. Props OriginalEXE, SergeyBiryukov. Fixes #27034. git-svn-id: https://develop.svn.wordpress.org/trunk@31690 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/js/edit-comments.js | 2 +- src/wp-admin/js/inline-edit-post.js | 2 +- src/wp-admin/js/media.js | 2 +- src/wp-admin/js/theme.js | 2 +- src/wp-admin/js/widgets.js | 4 ++-- src/wp-includes/js/media/views.js | 2 +- src/wp-includes/js/media/views/embed/link.js | 2 +- src/wp-includes/js/plupload/handlers.js | 2 +- src/wp-includes/js/wp-ajax-response.js | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/wp-admin/js/edit-comments.js b/src/wp-admin/js/edit-comments.js index 78c46174ea..72b81e273b 100644 --- a/src/wp-admin/js/edit-comments.js +++ b/src/wp-admin/js/edit-comments.js @@ -351,7 +351,7 @@ commentReply = { $('#com-reply').append( replyrow ); $('#replycontent').css('height', '').val(''); $('#edithead input').val(''); - $('.error', replyrow).html('').hide(); + $('.error', replyrow).empty().hide(); $('.spinner', replyrow).hide(); this.cid = ''; diff --git a/src/wp-admin/js/inline-edit-post.js b/src/wp-admin/js/inline-edit-post.js index 9f1b13b044..6d9753455e 100644 --- a/src/wp-admin/js/inline-edit-post.js +++ b/src/wp-admin/js/inline-edit-post.js @@ -286,7 +286,7 @@ inlineEditPost = { if ( 'bulk-edit' === id ) { $('table.widefat #bulk-edit').removeClass('inline-editor').hide().siblings('tr.hidden').remove(); - $('#bulk-titles').html(''); + $('#bulk-titles').empty(); $('#inlineedit').append( $('#bulk-edit') ); } else { $('#'+id).siblings('tr.hidden').addBack().remove(); diff --git a/src/wp-admin/js/media.js b/src/wp-admin/js/media.js index 64b322497b..b235bfc9ca 100644 --- a/src/wp-admin/js/media.js +++ b/src/wp-admin/js/media.js @@ -32,7 +32,7 @@ var findPosts; }, close: function() { - $('#find-posts-response').html(''); + $('#find-posts-response').empty(); $('#find-posts').hide(); $( '.ui-find-overlay' ).hide(); }, diff --git a/src/wp-admin/js/theme.js b/src/wp-admin/js/theme.js index 83c67a2f29..fbd378961f 100644 --- a/src/wp-admin/js/theme.js +++ b/src/wp-admin/js/theme.js @@ -900,7 +900,7 @@ themes.view.Themes = wp.Backbone.View.extend({ // and keeping theme count in sync render: function() { // Clear the DOM, please - this.$el.html( '' ); + this.$el.empty(); // If the user doesn't have switch capabilities // or there is only one theme in the collection diff --git a/src/wp-admin/js/widgets.js b/src/wp-admin/js/widgets.js index 2e1dcd1b80..a149a29e88 100644 --- a/src/wp-admin/js/widgets.js +++ b/src/wp-admin/js/widgets.js @@ -233,7 +233,7 @@ wpWidgets = { }, drop: function(e,ui) { ui.draggable.addClass('deleting'); - $('#removing-widget').hide().children('span').html(''); + $('#removing-widget').hide().children('span').empty(); }, over: function(e,ui) { ui.draggable.addClass('deleting'); @@ -247,7 +247,7 @@ wpWidgets = { out: function(e,ui) { ui.draggable.removeClass('deleting'); $('div.widget-placeholder').show(); - $('#removing-widget').hide().children('span').html(''); + $('#removing-widget').hide().children('span').empty(); } }); diff --git a/src/wp-includes/js/media/views.js b/src/wp-includes/js/media/views.js index 3aee9fbaec..a2f3f22614 100644 --- a/src/wp-includes/js/media/views.js +++ b/src/wp-includes/js/media/views.js @@ -4604,7 +4604,7 @@ EmbedLink = Settings.extend({ var url = this.model.get( 'url' ); // clear out previous results - this.$('.embed-container').hide().find('.embed-preview').html(''); + this.$('.embed-container').hide().find('.embed-preview').empty(); this.$( '.setting' ).hide(); // only proceed with embed if the field contains more than 6 characters diff --git a/src/wp-includes/js/media/views/embed/link.js b/src/wp-includes/js/media/views/embed/link.js index bfdc8974be..93b544bf3d 100644 --- a/src/wp-includes/js/media/views/embed/link.js +++ b/src/wp-includes/js/media/views/embed/link.js @@ -27,7 +27,7 @@ EmbedLink = Settings.extend({ var url = this.model.get( 'url' ); // clear out previous results - this.$('.embed-container').hide().find('.embed-preview').html(''); + this.$('.embed-container').hide().find('.embed-preview').empty(); this.$( '.setting' ).hide(); // only proceed with embed if the field contains more than 6 characters diff --git a/src/wp-includes/js/plupload/handlers.js b/src/wp-includes/js/plupload/handlers.js index d6a9958c7e..1396a2d3be 100644 --- a/src/wp-includes/js/plupload/handlers.js +++ b/src/wp-includes/js/plupload/handlers.js @@ -448,7 +448,7 @@ jQuery(document).ready(function($){ uploader.init(); uploader.bind('FilesAdded', function( up, files ) { - $('#media-upload-error').html(''); + $('#media-upload-error').empty(); uploadStart(); plupload.each( files, function( file ) { diff --git a/src/wp-includes/js/wp-ajax-response.js b/src/wp-includes/js/wp-ajax-response.js index eb46267852..45160a76a8 100644 --- a/src/wp-includes/js/wp-ajax-response.js +++ b/src/wp-includes/js/wp-ajax-response.js @@ -12,7 +12,7 @@ var wpAjax = jQuery.extend( { return r; }, parseAjaxResponse: function( x, r, e ) { // 1 = good, 0 = strange (bad data?), -1 = you lack permission - var parsed = {}, re = jQuery('#' + r).html(''), err = ''; + var parsed = {}, re = jQuery('#' + r).empty(), err = ''; if ( x && typeof x == 'object' && x.getElementsByTagName('wp_ajax') ) { parsed.responses = [];