From 6cc9452def82e64b09f1b3a2bfcec01b27c39da1 Mon Sep 17 00:00:00 2001 From: Felix Arntz Date: Thu, 10 Jan 2019 21:16:49 +0000 Subject: [PATCH] General: Fix existing coding standard violations in bookmark tests, as outlined in [44546]. See #43977. git-svn-id: https://develop.svn.wordpress.org/trunk@44547 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/bookmark/getBookmarks.php | 27 ++++++++++++------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/tests/phpunit/tests/bookmark/getBookmarks.php b/tests/phpunit/tests/bookmark/getBookmarks.php index c605a9f0c5..3382ab893d 100644 --- a/tests/phpunit/tests/bookmark/getBookmarks.php +++ b/tests/phpunit/tests/bookmark/getBookmarks.php @@ -93,8 +93,9 @@ class Tests_Bookmark_GetBookmarks extends WP_UnitTestCase { 'exclude' => ',,', ) ); + $found_ids = array(); - foreach( $found as $bookmark ) { + foreach ( $found as $bookmark ) { $found_ids[] = $bookmark->link_id; } @@ -110,20 +111,25 @@ class Tests_Bookmark_GetBookmarks extends WP_UnitTestCase { 'include' => ',,', ) ); + $found_ids = array(); - foreach( $found as $bookmark ) { - $found_ids[] = $bookmark->link_id; - } + foreach ( $found as $bookmark ) { + $found_ids[] = $bookmark->link_id; + } // equal sets != same order. $this->assertEqualSets( $bookmarks, $found_ids ); } public function test_category_param_propelry_gets_parsed_as_list() { - $bookmarks = self::factory()->bookmark->create_many( 3 ); - $categories = self::factory()->term->create_many( 3, array( - 'taxonomy' => 'link_category', - ) ); + $bookmarks = self::factory()->bookmark->create_many( 3 ); + $categories = self::factory()->term->create_many( + 3, + array( + 'taxonomy' => 'link_category', + ) + ); + $add = wp_add_object_terms( $bookmarks[0], $categories[0], 'link_category' ); $add = wp_add_object_terms( $bookmarks[1], $categories[1], 'link_category' ); $add = wp_add_object_terms( $bookmarks[2], $categories[2], 'link_category' ); @@ -133,10 +139,11 @@ class Tests_Bookmark_GetBookmarks extends WP_UnitTestCase { 'category' => ',,', ) ); + $found_ids = array(); - foreach( $found as $bookmark ) { + foreach ( $found as $bookmark ) { $found_ids[] = $bookmark->link_id; - } + } // equal sets != same order. $this->assertEqualSets( $bookmarks, $found_ids );