vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Query: Expand the list of operators available to compare_key in WP_Meta_Query.

Browse Source 
`compare_key`, introduced in #42409, previously supported only `=` and `LIKE`
operators. This changeset introduces a number of other operators: `!=`, `IN`,
`NOT IN`, `NOT LIKE`, `RLIKE`, `REGEXP`, `NOT REGEXP`, `EXISTS`, and `NOT EXISTS`
(the latter two aliased to `=` and `!=`, respectively). To support case-sensitive
regular expression key comparisons, the new `type_key` parameter will force
a MySQL `CAST` when 'BINARY' is passed.

Props soulseekah.
Fixes #43346.

git-svn-id: https://develop.svn.wordpress.org/trunk@46188 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2019-09-19 15:02:20 +00:00
parent 7e69921a5a
commit 6eabc83b81
4 changed files with 392 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/phpunit/tests/meta/query.php
View File

@@ -737,6 +737,42 @@ class Tests_Meta_Query extends WP_UnitTestCase {
$this->assertSame( 1, substr_count( $sql['where'], "$wpdb->postmeta.meta_value =" ) );
}
/**
* Verifies only that meta_type_key is passed. See query/metaQuery.php for more complete tests.
*
* @ticket 43446
*/
public function test_meta_type_key_should_be_passed_to_meta_query() {
$posts = self::factory()->post->create_many( 3 );
add_post_meta( $posts[0], 'AAA_FOO_AAA', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_aaa', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_bbb', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_aaa', 'abc' );
$q = new WP_Query(
array(
'meta_key' => 'AAA_foo_.*',
'meta_compare_key' => 'REGEXP',
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[0], $posts[2] ), $q->posts );
$q = new WP_Query(
array(
'meta_key' => 'AAA_FOO_.*',
'meta_compare_key' => 'REGEXP',
'meta_type_key' => 'BINARY',
'fields' => 'ids',
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[0] ), $q->posts );
}
/**
* This is the clause that ensures that empty arrays are not valid queries.
*/

243
tests/phpunit/tests/query/metaQuery.php
View File

@@ -1922,4 +1922,247 @@ class Tests_Query_MetaQuery extends WP_UnitTestCase {
$this->assertEqualSets( array( $posts[0] ), $q->posts );
}
/**
* @ticket 43446
*/
public function test_compare_key_not_equals() {
$posts = self::factory()->post->create_many( 3 );
add_post_meta( $posts[0], 'aaa_foo_aaa', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_aaa', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_bbb', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_ccc', 'abc' );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => '!=',
'key' => 'aaa_foo_bbb',
'value' => 'abc',
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[0], $posts[1] ), $q->posts );
}
/**
* @ticket 43446
*/
public function test_compare_key_not_like() {
$posts = self::factory()->post->create_many( 3 );
add_post_meta( $posts[0], 'aaa_foo_aaa', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_aaa', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_ccc', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_bbb', 'abc' );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => 'NOT LIKE',
'key' => 'aaa_bar',
'value' => 'abc',
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[0], $posts[2] ), $q->posts );
}
/**
* @ticket 43446
*/
public function test_compare_key_in() {
$posts = self::factory()->post->create_many( 3 );
add_post_meta( $posts[0], 'aaa_foo_aaa', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_aaa', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_bbb', 'abc' );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => 'IN',
'key' => array( 'aaa_foo_bbb', 'aaa_bar_aaa' ),
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[1], $posts[2] ), $q->posts );
}
/**
* @ticket 43446
*/
public function test_compare_key_not_in() {
$posts = self::factory()->post->create_many( 3 );
add_post_meta( $posts[0], 'aaa_foo_aaa', 'abc' );
add_post_meta( $posts[0], 'aaa_foo_ddd', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_aaa', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_bbb', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_ccc', 'abc' );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => 'NOT IN',
'key' => array( 'aaa_foo_bbb', 'aaa_foo_ddd' ),
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[1] ), $q->posts );
}
/**
* @ticket 43446
*/
public function test_compare_key_not_exists() {
$posts = self::factory()->post->create_many( 3 );
add_post_meta( $posts[0], 'aaa_foo_aaa', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_aaa', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_bbb', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_ccc', 'abc' );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => 'NOT EXISTS',
'key' => 'aaa_foo_bbb',
'value' => 'abc',
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[0], $posts[1] ), $q->posts );
}
/**
* @ticket 43446
*/
public function test_compare_key_exists() {
$posts = self::factory()->post->create_many( 3 );
add_post_meta( $posts[0], 'aaa_foo_aaa', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_aaa', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_bbb', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_ccc', 'abc' );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => 'EXISTS',
'key' => 'aaa_foo_bbb',
'value' => 'abc',
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[2] ), $q->posts );
}
/**
* @ticket 43446
*/
public function test_compare_key_regexp_rlike() {
$posts = self::factory()->post->create_many( 3 );
add_post_meta( $posts[0], 'AAA_FOO_AAA', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_aaa', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_bbb', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_aaa', 'abc' );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => 'REGEXP',
'key' => 'AAA_foo_.*',
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[0], $posts[2] ), $q->posts );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => 'RLIKE',
'key' => 'AAA_FOO_.*',
'type_key' => 'BINARY',
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[0] ), $q->posts );
}
/**
* @ticket 43446
*/
public function test_compare_key_not_regexp() {
$posts = self::factory()->post->create_many( 3 );
add_post_meta( $posts[0], 'AAA_FOO_AAA', 'abc' );
add_post_meta( $posts[0], 'AAA_foo_AAA', 'abc' );
add_post_meta( $posts[1], 'aaa_bar_aaa', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_bbb', 'abc' );
add_post_meta( $posts[2], 'aaa_foo_aaa', 'abc' );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => 'NOT REGEXP',
'key' => 'AAA_foo_.*',
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[1] ), $q->posts );
$q = new WP_Query(
array(
'meta_query' => array(
array(
'compare_key' => 'NOT REGEXP',
'key' => 'AAA_FOO_.*',
'type_key' => 'BINARY',
),
),
'fields' => 'ids',
)
);
$this->assertEqualSets( array( $posts[1], $posts[2] ), $q->posts );
}
}