From 72ad4e1bcfecab298f0798c0acb2367a754d7f2b Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
Date: Wed, 13 Jan 2021 14:06:30 +0000
Subject: [PATCH] Accessibility: Administration: Remove `<strong>` tags from
 labels on plugin/theme editor screens.

If every single label is emphasized with a `<strong>` tag, none of them is really emphasized anymore.

This removes the tags in favor of CSS styling, for consistency with the other labels on the screen.

Props chemiker, audrasjb, mukesh27, paaljoachim, estelaris, ibdz, SergeyBiryukov.
Fixes #52232.

git-svn-id: https://develop.svn.wordpress.org/trunk@49958 602fd350-edb4-49c9-b593-d223f7449a82
---
 src/wp-admin/css/common.css    | 7 +++++--
 src/wp-admin/plugin-editor.php | 2 +-
 src/wp-admin/theme-editor.php  | 2 +-
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/wp-admin/css/common.css b/src/wp-admin/css/common.css
index 9da493c94c..2495ee3a1d 100644
--- a/src/wp-admin/css/common.css
+++ b/src/wp-admin/css/common.css
@@ -3290,11 +3290,15 @@ img {
 	display: none;
 }
 
+#theme-plugin-editor-selector,
+#theme-plugin-editor-label,
+#documentation label {
+	font-weight: 600;
+}
 
 #theme-plugin-editor-label {
 	display: inline-block;
 	margin-bottom: 1em;
-	font-weight: 600;
 }
 
 /* rtl:ignore */
@@ -3390,7 +3394,6 @@ img {
 #documentation label {
 	line-height: 1.8;
 	vertical-align: baseline;
-	font-weight: 600;
 }
 
 .fileedit-sub {
diff --git a/src/wp-admin/plugin-editor.php b/src/wp-admin/plugin-editor.php
index 7467ace6aa..a5be77d035 100644
--- a/src/wp-admin/plugin-editor.php
+++ b/src/wp-admin/plugin-editor.php
@@ -216,7 +216,7 @@ $content = esc_textarea( $content );
 </div>
 <div class="alignright">
 	<form action="plugin-editor.php" method="get">
-		<strong><label for="plugin"><?php _e( 'Select plugin to edit:' ); ?> </label></strong>
+		<label for="plugin" id="theme-plugin-editor-selector"><?php _e( 'Select plugin to edit:' ); ?> </label>
 		<select name="plugin" id="plugin">
 		<?php
 		foreach ( $plugins as $plugin_key => $a_plugin ) {
diff --git a/src/wp-admin/theme-editor.php b/src/wp-admin/theme-editor.php
index 3cf24cc77e..c162ce4c14 100644
--- a/src/wp-admin/theme-editor.php
+++ b/src/wp-admin/theme-editor.php
@@ -222,7 +222,7 @@ if ( $file_description !== $file_show ) {
 </div>
 <div class="alignright">
 	<form action="theme-editor.php" method="get">
-		<strong><label for="theme"><?php _e( 'Select theme to edit:' ); ?> </label></strong>
+		<label for="theme" id="theme-plugin-editor-selector"><?php _e( 'Select theme to edit:' ); ?> </label>
 		<select name="theme" id="theme">
 		<?php
 		foreach ( wp_get_themes( array( 'errors' => null ) ) as $a_stylesheet => $a_theme ) {