From 735ecc0ba9543c321def1268cc50421be45829fe Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Thu, 24 Jun 2021 06:51:54 +0000 Subject: [PATCH] Tests: Use `assertSame()` in `_wp_to_kebab_case()` tests. This ensures that not only the return values match the expected results, but also that their type is the same. Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable. Follow-up to [51079], [51198]. See #52482, #52625, #53397. git-svn-id: https://develop.svn.wordpress.org/trunk@51225 602fd350-edb4-49c9-b593-d223f7449a82 --- .../phpunit/tests/functions/wpToKebabCase.php | 50 +++++++++---------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/tests/phpunit/tests/functions/wpToKebabCase.php b/tests/phpunit/tests/functions/wpToKebabCase.php index 831c01c1a7..24b2e2d187 100644 --- a/tests/phpunit/tests/functions/wpToKebabCase.php +++ b/tests/phpunit/tests/functions/wpToKebabCase.php @@ -11,30 +11,30 @@ class Tests_Functions_wpToKebabCase extends WP_UnitTestCase { public function test_wp_to_kebab_case() { - $this->assertEquals( 'white', _wp_to_kebab_case( 'white' ) ); - $this->assertEquals( 'white-black', _wp_to_kebab_case( 'white+black' ) ); - $this->assertEquals( 'white-black', _wp_to_kebab_case( 'white:black' ) ); - $this->assertEquals( 'white-black', _wp_to_kebab_case( 'white*black' ) ); - $this->assertEquals( 'white-black', _wp_to_kebab_case( 'white.black' ) ); - $this->assertEquals( 'white-black', _wp_to_kebab_case( 'white black' ) ); - $this->assertEquals( 'white-black', _wp_to_kebab_case( 'white black' ) ); - $this->assertEquals( 'white-to-black', _wp_to_kebab_case( 'white-to-black' ) ); - $this->assertEquals( 'white-2-white', _wp_to_kebab_case( 'white2white' ) ); - $this->assertEquals( 'white-2nd', _wp_to_kebab_case( 'white2nd' ) ); - $this->assertEquals( 'white-2-ndcolor', _wp_to_kebab_case( 'white2ndcolor' ) ); - $this->assertEquals( 'white-2nd-color', _wp_to_kebab_case( 'white2ndColor' ) ); - $this->assertEquals( 'white-2nd-color', _wp_to_kebab_case( 'white2nd_color' ) ); - $this->assertEquals( 'white-23-color', _wp_to_kebab_case( 'white23color' ) ); - $this->assertEquals( 'white-23', _wp_to_kebab_case( 'white23' ) ); - $this->assertEquals( '23-color', _wp_to_kebab_case( '23color' ) ); - $this->assertEquals( 'white-4th', _wp_to_kebab_case( 'white4th' ) ); - $this->assertEquals( 'font-2-xl', _wp_to_kebab_case( 'font2xl' ) ); - $this->assertEquals( 'white-to-white', _wp_to_kebab_case( 'whiteToWhite' ) ); - $this->assertEquals( 'white-t-owhite', _wp_to_kebab_case( 'whiteTOwhite' ) ); - $this->assertEquals( 'whit-eto-white', _wp_to_kebab_case( 'WHITEtoWHITE' ) ); - $this->assertEquals( '42', _wp_to_kebab_case( 42 ) ); - $this->assertEquals( 'ive-done', _wp_to_kebab_case( "i've done" ) ); - $this->assertEquals( 'ffffff', _wp_to_kebab_case( '#ffffff' ) ); - $this->assertEquals( 'ffffff', _wp_to_kebab_case( '$ffffff' ) ); + $this->assertSame( 'white', _wp_to_kebab_case( 'white' ) ); + $this->assertSame( 'white-black', _wp_to_kebab_case( 'white+black' ) ); + $this->assertSame( 'white-black', _wp_to_kebab_case( 'white:black' ) ); + $this->assertSame( 'white-black', _wp_to_kebab_case( 'white*black' ) ); + $this->assertSame( 'white-black', _wp_to_kebab_case( 'white.black' ) ); + $this->assertSame( 'white-black', _wp_to_kebab_case( 'white black' ) ); + $this->assertSame( 'white-black', _wp_to_kebab_case( 'white black' ) ); + $this->assertSame( 'white-to-black', _wp_to_kebab_case( 'white-to-black' ) ); + $this->assertSame( 'white-2-white', _wp_to_kebab_case( 'white2white' ) ); + $this->assertSame( 'white-2nd', _wp_to_kebab_case( 'white2nd' ) ); + $this->assertSame( 'white-2-ndcolor', _wp_to_kebab_case( 'white2ndcolor' ) ); + $this->assertSame( 'white-2nd-color', _wp_to_kebab_case( 'white2ndColor' ) ); + $this->assertSame( 'white-2nd-color', _wp_to_kebab_case( 'white2nd_color' ) ); + $this->assertSame( 'white-23-color', _wp_to_kebab_case( 'white23color' ) ); + $this->assertSame( 'white-23', _wp_to_kebab_case( 'white23' ) ); + $this->assertSame( '23-color', _wp_to_kebab_case( '23color' ) ); + $this->assertSame( 'white-4th', _wp_to_kebab_case( 'white4th' ) ); + $this->assertSame( 'font-2-xl', _wp_to_kebab_case( 'font2xl' ) ); + $this->assertSame( 'white-to-white', _wp_to_kebab_case( 'whiteToWhite' ) ); + $this->assertSame( 'white-t-owhite', _wp_to_kebab_case( 'whiteTOwhite' ) ); + $this->assertSame( 'whit-eto-white', _wp_to_kebab_case( 'WHITEtoWHITE' ) ); + $this->assertSame( '42', _wp_to_kebab_case( 42 ) ); + $this->assertSame( 'ive-done', _wp_to_kebab_case( "i've done" ) ); + $this->assertSame( 'ffffff', _wp_to_kebab_case( '#ffffff' ) ); + $this->assertSame( 'ffffff', _wp_to_kebab_case( '$ffffff' ) ); } }