diff --git a/src/wp-includes/post.php b/src/wp-includes/post.php index 3b3d55fe19..37f97d97fb 100644 --- a/src/wp-includes/post.php +++ b/src/wp-includes/post.php @@ -3703,7 +3703,7 @@ function wp_unique_post_slug( $slug, $post_ID, $post_status, $post_type, $post_p * Page slugs must be unique within their own trees. Pages are in a separate * namespace than posts so page slugs are allowed to overlap post slugs. */ - $check_sql = "SELECT post_name FROM $wpdb->posts WHERE post_name = %s AND post_type = %s AND ID != %d AND post_parent = %d LIMIT 1"; + $check_sql = "SELECT post_name FROM $wpdb->posts WHERE post_name = %s AND post_type IN ( %s, 'attachment' ) AND ID != %d AND post_parent = %d LIMIT 1"; $post_name_check = $wpdb->get_var( $wpdb->prepare( $check_sql, $slug, $post_type, $post_ID, $post_parent ) ); /** diff --git a/tests/phpunit/tests/post.php b/tests/phpunit/tests/post.php index 23754589dd..ae549e0444 100644 --- a/tests/phpunit/tests/post.php +++ b/tests/phpunit/tests/post.php @@ -504,10 +504,17 @@ class Tests_Post extends WP_UnitTestCase { * @ticket 15665 */ function test_get_page_by_path_priority() { + global $wpdb; + $attachment = $this->factory->post->create_and_get( array( 'post_title' => 'some-page', 'post_type' => 'attachment' ) ); $page = $this->factory->post->create_and_get( array( 'post_title' => 'some-page', 'post_type' => 'page' ) ); $other_att = $this->factory->post->create_and_get( array( 'post_title' => 'some-other-page', 'post_type' => 'attachment' ) ); + $wpdb->update( $wpdb->posts, array( 'post_name' => 'some-page' ), array( 'ID' => $page->ID ) ); + clean_post_cache( $page->ID ); + + $page = get_post( $page->ID ); + $this->assertEquals( 'some-page', $attachment->post_name ); $this->assertEquals( 'some-page', $page->post_name ); @@ -987,6 +994,44 @@ class Tests_Post extends WP_UnitTestCase { _unregister_post_type( 'post-type-1' ); } + /** + * @ticket 18962 + */ + function test_wp_unique_post_slug_with_hierarchy_and_attachments() { + register_post_type( 'post-type-1', array( 'hierarchical' => true ) ); + + $args = array( + 'post_type' => 'post-type-1', + 'post_name' => 'some-slug', + 'post_status' => 'publish', + ); + $one = $this->factory->post->create( $args ); + + $args = array( + 'post_mime_type' => 'image/jpeg', + 'post_type' => 'attachment', + 'post_name' => 'image' + ); + $attachment = $this->factory->attachment->create_object( 'image.jpg', $one, $args ); + + $args = array( + 'post_type' => 'post-type-1', + 'post_name' => 'image', + 'post_status' => 'publish', + 'post_parent' => $one + ); + $two = $this->factory->post->create( $args ); + + $this->assertEquals( 'some-slug', get_post( $one )->post_name ); + $this->assertEquals( 'image', get_post( $attachment )->post_name ); + $this->assertEquals( 'image-2', get_post( $two )->post_name ); + + // 'image' can be a child of image-2 + $this->assertEquals( 'image', wp_unique_post_slug( 'image', 0, 'publish', 'post-type-1', $two ) ); + + _unregister_post_type( 'post-type-1' ); + } + /** * @ticket 21212 */