vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-17 07:10:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Formatting: Make the check for empty text in wp_trim_excerpt() more resilient.

Browse Source 
This addresses a regression in [47808], which caused excerpts to be generated from post content if an empty string is passed, but not for other values considered empty, e.g. `null` or `false`.

Props riaanlom, laxman-prajapati, SergeyBiryukov.
Fixes #51042.

git-svn-id: https://develop.svn.wordpress.org/trunk@48817 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2020-08-18 15:08:19 +00:00
parent 1911eae4a1
commit 76c599ced2
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/formatting/WpTrimExcerpt.php
+15
View File
@@ -66,4 +66,19 @@ class Tests_Formatting_WpTrimExcerpt extends WP_UnitTestCase {
}
}
}
/**
* @ticket 51042
*/
public function test_should_generate_excerpt_for_empty_values() {
$post = self::factory()->post->create(
array(
'post_content' => 'Post content',
)
);
$this->assertSame( 'Post content', wp_trim_excerpt( '', $post ) );
$this->assertSame( 'Post content', wp_trim_excerpt( null, $post ) );
$this->assertSame( 'Post content', wp_trim_excerpt( false, $post ) );
}
}