From 7894562b5099e8db8e706cdce3177f63344b4488 Mon Sep 17 00:00:00 2001 From: Aaron Jorbin Date: Sat, 26 Sep 2015 20:58:22 +0000 Subject: [PATCH] Revert change from true to false in multisite upload test This change was introduced in [34601]. 0 is a special snowflake. The code treats it as if it should fall back to the default, rather than respecting 0 as 0. Essentially, 0 means 100. WAT? This has been discussed previusly in https://core.trac.wordpress.org/ticket/19538#comment:10. This test should return True right now, but the behavior should be discussed and in the future 0 may mean 0. See #34037 Props jorbin, boonebgorges git-svn-id: https://develop.svn.wordpress.org/trunk@34606 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/multisite/site.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/phpunit/tests/multisite/site.php b/tests/phpunit/tests/multisite/site.php index 130134e19c..9e01fd771d 100644 --- a/tests/phpunit/tests/multisite/site.php +++ b/tests/phpunit/tests/multisite/site.php @@ -1107,7 +1107,7 @@ class Tests_Multisite_Site extends WP_UnitTestCase { function test_is_upload_space_available_upload_space_0() { update_site_option( 'upload_space_check_disabled', false ); update_site_option( 'blog_upload_space', 0 ); - $this->assertFalse( is_upload_space_available() ); + $this->assertTrue( is_upload_space_available() ); } function test_is_upload_space_available_upload_space_negative() {