vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-12 21:00:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't call the size function count() as part of a test condition in loops. Compute the size beforehand, and not on each iteration.

Browse Source 
Scrutinizer added a Performance label: these are the only violations.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31554 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-02-26 05:47:53 +00:00
parent a524e05572
commit 79706ee8a8
5 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wp-admin/includes/image-edit.php
+1 -1
View File
@@ -461,7 +461,7 @@ function image_edit_apply_changes( $image, $changes ) {
// Combine operations.
if ( count($changes) > 1 ) {
$filtered = array($changes[0]);
for ( $i = 0, $j = 1; $j < count($changes); $j++ ) {
for ( $i = 0, $j = 1, $c = count( $changes ); $j < $c; $j++ ) {
$combined = false;
if ( $filtered[$i]->type == $changes[$j]->type ) {
switch ( $filtered[$i]->type ) {