vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Return WP_Term objects from get_terms().

Browse Source 
Props boonebgorges, flixos90, DrewAPicture.
See #14162.

git-svn-id: https://develop.svn.wordpress.org/trunk@34998 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges 2015-10-10 02:12:40 +00:00
parent 134a7af0fc
commit 797ddb60ba
2 changed files with 45 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/wp-includes/taxonomy-functions.php
View File

@ -991,7 +991,8 @@ function get_term_to_edit( $id, $taxonomy ) {
* @since 2.3.0
* @since 4.2.0 Introduced 'name' and 'childless' parameters.
* @since 4.4.0 Introduced the ability to pass 'term_id' as an alias of 'id' for the `orderby` parameter.
* Introduced the 'meta_query' and 'update_term_meta_cache' parameters.
* Introduced the 'meta_query' and 'update_term_meta_cache' parameters. Converted to return
* a list of WP_Term objects.
*
* @global wpdb $wpdb WordPress database abstraction object.
* @global array $wp_filter
@ -1052,8 +1053,8 @@ function get_term_to_edit( $id, $taxonomy ) {
* @type array $meta_query Meta query clauses to limit retrieved terms by.
* See `WP_Meta_Query`. Default empty.
* }
* @return array|int|WP_Error List of Term Objects and their children. Will return WP_Error, if any of $taxonomies
* do not exist.
* @return array|int|WP_Error List of WP_Term instances and their children. Will return WP_Error, if any of $taxonomies
* do not exist.
*/
function get_terms( $taxonomies, $args = '' ) {
global $wpdb;
@ -1493,6 +1494,8 @@ function get_terms( $taxonomies, $args = '' ) {
foreach ( $terms as $term ) {
$_terms[ $term->term_id ] = $term->slug;
}
} else {
$_terms = array_map( 'get_term', $terms );
}
if ( ! empty( $_terms ) ) {

39
tests/phpunit/tests/term/getTerms.php
View File

@ -1572,6 +1572,45 @@ class Tests_Term_getTerms extends WP_UnitTestCase {
$this->assertEqualSets( array( $terms[0], $terms[1] ), $found );
}
/**
* @ticket 14162
*/
public function test_should_return_wp_term_objects() {
register_taxonomy( 'wptests_tax', 'post' );
$terms = $this->factory->term->create_many( 2, array( 'taxonomy' => 'wptests_tax' ) );
$found = get_terms( 'wptests_tax', array(
'hide_empty' => false,
'fields' => 'all',
) );
$this->assertNotEmpty( $found );
foreach ( $found as $term ) {
$this->assertInstanceOf( 'WP_Term', $term );
}
}
/**
* @ticket 14162
*/
public function test_should_prime_individual_term_cache_when_fields_is_all() {
global $wpdb;
register_taxonomy( 'wptests_tax', 'post' );
$terms = $this->factory->term->create_many( 2, array( 'taxonomy' => 'wptests_tax' ) );
$found = get_terms( 'wptests_tax', array(
'hide_empty' => false,
'fields' => 'all',
) );
$num_queries = $wpdb->num_queries;
$term0 = get_term( $terms[0] );
$this->assertSame( $num_queries, $wpdb->num_queries );
}
protected function create_hierarchical_terms_and_posts() {
$terms = array();