From 7b95dc861b6ec3594f43b508f3317af19c48d497 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Thu, 7 Aug 2014 20:53:03 +0000 Subject: [PATCH] Media Grid: use a `media.view.Label` instance in the toolbar for the screen reader text for Search. See #29026. git-svn-id: https://develop.svn.wordpress.org/trunk@29437 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/js/media-views.js | 10 ++++++++-- src/wp-includes/media.php | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/js/media-views.js b/src/wp-includes/js/media-views.js index 4f35b1fc4c..f576ce7fe2 100644 --- a/src/wp-includes/js/media-views.js +++ b/src/wp-includes/js/media-views.js @@ -5766,13 +5766,19 @@ }) ); if ( this.options.search ) { + // Search is an input, screen reader text needs to be rendered before + this.toolbar.set( 'searchLabel', new media.view.Label({ + value: l10n.searchMediaLabel, + attributes: { + 'for': 'media-search-input' + }, + priority: 60 + }).render() ); this.toolbar.set( 'search', new media.view.Search({ controller: this.controller, model: this.collection.props, priority: 60 }).render() ); - screenReaderText = $( '' ); - this.toolbar.get( 'search' ).$el.before( screenReaderText ); } if ( this.options.dragInfo ) { diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php index 8904063112..17f20cd79e 100644 --- a/src/wp-includes/media.php +++ b/src/wp-includes/media.php @@ -2941,6 +2941,7 @@ function wp_enqueue_media( $args = array() ) { 'deletePermanently' => __( 'Delete Permanently' ), 'apply' => __( 'Apply' ), 'filterByDate' => __( 'Filter by date' ), + 'searchMediaLabel' => __( 'Search Media' ), // Library Details 'attachmentDetails' => __( 'Attachment Details' ),