From 7de1b7c0ae272ae71d1ad16368ca5aaeef2e2df7 Mon Sep 17 00:00:00 2001 From: Mike Schroder Date: Fri, 9 Jul 2021 08:12:29 +0000 Subject: [PATCH] Customizer: Skip animations when they have no duration. In addition to skipping animations when a related style doesn't Exist, now checks to see if animation styles are Empty as well. This resolves a case where the Gutenberg End to End tests were failing, due to running with animations disabled. This change should also help some users who are intentionally overriding styles to remove animations. See https://github.com/WordPress/gutenberg/issues/32024 for the original Gutenberg issue. Props zieladam, isabel_brison, kevin940726, desrosj, mikeschroder. Fixes #53562. See #53542. git-svn-id: https://develop.svn.wordpress.org/trunk@51389 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/_enqueues/wp/customize/controls.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/_enqueues/wp/customize/controls.js b/src/js/_enqueues/wp/customize/controls.js index c8ee3de8df..e5d079293b 100644 --- a/src/js/_enqueues/wp/customize/controls.js +++ b/src/js/_enqueues/wp/customize/controls.js @@ -906,7 +906,7 @@ 'WebkitTransition': 'webkitTransitionEnd' }; prop = _.find( _.keys( transitions ), function( prop ) { - return ! _.isUndefined( el.style[ prop ] ); + return ! _.isUndefined( el.style[ prop ] ) && ! _.isEmpty( el.style[ prop ] ); } ); if ( prop ) { return transitions[ prop ];