From 7f000f2fdd27234fe98be423b9880a450ee21c1e Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Thu, 7 Aug 2014 06:19:29 +0000 Subject: [PATCH] Video: use `auto` instead of actual height for the responsive wrapper in generated markup. See #29110. git-svn-id: https://develop.svn.wordpress.org/trunk@29430 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/media-template.php | 4 ++-- src/wp-includes/media.php | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/media-template.php b/src/wp-includes/media-template.php index 084228e27f..657e8d0fcf 100644 --- a/src/wp-includes/media-template.php +++ b/src/wp-includes/media-template.php @@ -71,7 +71,7 @@ function wp_underscore_video_template() { } if ( h ) { - h_rule = ' height: ' + h + 'px;'; + h_rule = ' height: auto'; } #>
@@ -297,7 +297,7 @@ function wp_print_media_templates() { w_rule = ' width: ' + wp.media.view.settings.contentWidth + 'px;'; } if ( data.height ) { - h_rule = ' height: ' + data.height + 'px;'; + h_rule = ' height: auto'; } #>
diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php index 09853648de..8a82beb974 100644 --- a/src/wp-includes/media.php +++ b/src/wp-includes/media.php @@ -1880,6 +1880,8 @@ function wp_video_shortcode( $attr, $content = '' ) { } if ( ! empty( $atts['height'] ) ) { $height_rule = sprintf( ' height: %dpx;', $atts['height'] ); + } else { + $height_rule = ' height: auto;'; } $output = sprintf( '
%s
', $width_rule, $height_rule, $html );