diff --git a/tests/phpunit/includes/abstract-testcase.php b/tests/phpunit/includes/abstract-testcase.php index 3af8e39351..1c7fe55e6d 100644 --- a/tests/phpunit/includes/abstract-testcase.php +++ b/tests/phpunit/includes/abstract-testcase.php @@ -660,12 +660,27 @@ abstract class WP_UnitTestCase_Base extends PHPUnit\Framework\TestCase { * Asserts that two values have the same type and value, with EOL differences discarded. * * @since 5.6.0 + * @since 5.8.0 Added support for nested arrays. * - * @param string $expected The expected value. - * @param string $actual The actual value. + * @param string|array $expected The expected value. + * @param string|array $actual The actual value. */ public function assertSameIgnoreEOL( $expected, $actual ) { - $this->assertSame( str_replace( "\r\n", "\n", $expected ), str_replace( "\r\n", "\n", $actual ) ); + $expected = map_deep( + $expected, + function ( $value ) { + return str_replace( "\r\n", "\n", $value ); + } + ); + + $actual = map_deep( + $actual, + function ( $value ) { + return str_replace( "\r\n", "\n", $value ); + } + ); + + $this->assertSame( $expected, $actual ); } /** diff --git a/tests/phpunit/tests/rest-api/rest-widget-types-controller.php b/tests/phpunit/tests/rest-api/rest-widget-types-controller.php index e5e3010edf..b09117ed94 100644 --- a/tests/phpunit/tests/rest-api/rest-widget-types-controller.php +++ b/tests/phpunit/tests/rest-api/rest-widget-types-controller.php @@ -307,7 +307,7 @@ class WP_Test_REST_Widget_Types_Controller extends WP_Test_REST_Controller_Testc $request = new WP_REST_Request( 'POST', '/wp/v2/widget-types/search/encode' ); $response = rest_get_server()->dispatch( $request ); $data = $response->get_data(); - $this->assertSame( + $this->assertSameIgnoreEOL( "
\n" . "\t\t\t\n" . "\t\t\t\n" . @@ -343,7 +343,7 @@ class WP_Test_REST_Widget_Types_Controller extends WP_Test_REST_Controller_Testc $request->set_param( 'number', 8 ); $response = rest_get_server()->dispatch( $request ); $data = $response->get_data(); - $this->assertSame( + $this->assertSameIgnoreEOL( "
\n" . "\t\t\t\n" . "\t\t\t\n" . @@ -385,7 +385,7 @@ class WP_Test_REST_Widget_Types_Controller extends WP_Test_REST_Controller_Testc ); $response = rest_get_server()->dispatch( $request ); $data = $response->get_data(); - $this->assertSame( + $this->assertSameIgnoreEOL( "
\n" . "\t\t\t\n" . "\t\t\t\n" . @@ -421,7 +421,7 @@ class WP_Test_REST_Widget_Types_Controller extends WP_Test_REST_Controller_Testc $request->set_param( 'form_data', 'widget-search[-1][title]=Updated+title' ); $response = rest_get_server()->dispatch( $request ); $data = $response->get_data(); - $this->assertSame( + $this->assertSameIgnoreEOL( "
\n" . "\t\t\t\n" . "\t\t\t\n" . @@ -465,7 +465,7 @@ class WP_Test_REST_Widget_Types_Controller extends WP_Test_REST_Controller_Testc ); $response = rest_get_server()->dispatch( $request ); $data = $response->get_data(); - $this->assertSame( + $this->assertSameIgnoreEOL( "
\n" . "\t\t\t\n" . "\t\t\t\n" . diff --git a/tests/phpunit/tests/rest-api/rest-widgets-controller.php b/tests/phpunit/tests/rest-api/rest-widgets-controller.php index 4fe50cc6bd..93453e20c2 100644 --- a/tests/phpunit/tests/rest-api/rest-widgets-controller.php +++ b/tests/phpunit/tests/rest-api/rest-widgets-controller.php @@ -381,12 +381,17 @@ class WP_Test_REST_Widgets_Controller extends WP_Test_REST_Controller_Testcase { $response = rest_get_server()->dispatch( $request ); $data = $response->get_data(); $data = $this->remove_links( $data ); - $this->assertEqualSets( + $this->assertSameIgnoreEOL( array( array( 'id' => 'text-1', 'id_base' => 'text', 'sidebar' => 'sidebar-1', + 'rendered' => '
', + 'rendered_form' => '' . "\n" . + ' ' . "\n" . + ' ' . "\n" . + ' ', 'instance' => array( 'encoded' => base64_encode( serialize( @@ -406,11 +411,6 @@ class WP_Test_REST_Widgets_Controller extends WP_Test_REST_Controller_Testcase { 'text' => 'Custom text test', ), ), - 'rendered' => '', - 'rendered_form' => '' . "\n" . - ' ' . "\n" . - ' ' . "\n" . - ' ', ), array( 'id' => 'testwidget', @@ -1207,11 +1207,16 @@ class WP_Test_REST_Widgets_Controller extends WP_Test_REST_Controller_Testcase { $request = new WP_REST_Request( 'DELETE', '/wp/v2/widgets/text-1' ); $response = rest_do_request( $request ); - $this->assertEqualSets( + $this->assertSameIgnoreEOL( array( 'id' => 'text-1', 'id_base' => 'text', 'sidebar' => 'wp_inactive_widgets', + 'rendered' => '', + 'rendered_form' => '' . "\n" . + ' ' . "\n" . + ' ' . "\n" . + ' ', 'instance' => array( 'encoded' => base64_encode( serialize( @@ -1231,11 +1236,6 @@ class WP_Test_REST_Widgets_Controller extends WP_Test_REST_Controller_Testcase { 'text' => 'Custom text test', ), ), - 'rendered' => '', - 'rendered_form' => '' . "\n" . - ' ' . "\n" . - ' ' . "\n" . - ' ', ), $response->get_data() ); @@ -1264,7 +1264,7 @@ class WP_Test_REST_Widgets_Controller extends WP_Test_REST_Controller_Testcase { $request->set_query_params( array( 'force' => true ) ); $response = rest_do_request( $request ); - $this->assertEqualSets( + $this->assertSameIgnoreEOL( array( 'deleted' => true, 'previous' => array( @@ -1272,6 +1272,11 @@ class WP_Test_REST_Widgets_Controller extends WP_Test_REST_Controller_Testcase { 'id' => 'text-1', 'id_base' => 'text', 'sidebar' => 'sidebar-1', + 'rendered' => '', + 'rendered_form' => '' . "\n" . + ' ' . "\n" . + ' ' . "\n" . + ' ', 'instance' => array( 'encoded' => base64_encode( serialize( @@ -1291,11 +1296,6 @@ class WP_Test_REST_Widgets_Controller extends WP_Test_REST_Controller_Testcase { 'text' => 'Custom text test', ), ), - 'rendered' => '', - 'rendered_form' => '' . "\n" . - ' ' . "\n" . - ' ' . "\n" . - ' ', ), ),