vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Script Loader: Optimize performance of _wp_normalize_relative_css_links() by more than 2x.

Browse Source 
* Replace `preg_match_all()` and its secondary `str_replace()` call with `preg_replace_callback()`.
* Fix case where paths beginning with `http` and `https` (but not `http:` and `https:`) were erroneously not counted as relative.
* Improve code style and readability by consolidating conditions and returning once.
* Use `str_starts_with()` consistently instead of `strpos()`.

Follow-up to [52036], [52695], and [52754].

Fixes #58069.
See #54243.


git-svn-id: https://develop.svn.wordpress.org/trunk@55658 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Weston Ruter
2023-04-19 01:24:40 +00:00
parent 19bd759db5
commit 8465dec59a
2 changed files with 34 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/phpunit/tests/dependencies/styles.php
View File

@@ -240,6 +240,14 @@ class Tests_Dependencies_Styles extends WP_UnitTestCase {
'css' => 'img {mask-image: url(\'data:image/svg+xml;utf8,<svg></svg>\');}',
'expected' => 'img {mask-image: url(\'data:image/svg+xml;utf8,<svg></svg>\');}',
),
'URLs with path beginning with http' => array(
'css' => 'p {background:url( "http-is-awesome.png" );}',
'expected' => 'p {background:url( "/wp-content/themes/test/http-is-awesome.png" );}',
),
'URLs with path beginning with https' => array(
'css' => 'p {background:url( "https-is-more-awesome.png" );}',
'expected' => 'p {background:url( "/wp-content/themes/test/https-is-more-awesome.png" );}',
),
);
}