From 85595b73ccf51cd2a45df4d729637e3d524e1081 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Thu, 8 Jan 2015 21:19:24 +0000 Subject: [PATCH] Overriding methods should do more than simply call the same method in the super class. See #30799. git-svn-id: https://develop.svn.wordpress.org/trunk@31101 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-media-list-table.php | 7 ------- src/wp-admin/includes/class-wp-upgrader-skins.php | 8 -------- src/wp-includes/class-wp-customize-control.php | 4 ---- 3 files changed, 19 deletions(-) diff --git a/src/wp-admin/includes/class-wp-media-list-table.php b/src/wp-admin/includes/class-wp-media-list-table.php index 219ebb3e12..e8885d2421 100644 --- a/src/wp-admin/includes/class-wp-media-list-table.php +++ b/src/wp-admin/includes/class-wp-media-list-table.php @@ -149,13 +149,6 @@ class WP_Media_List_Table extends WP_List_Table { _e( 'No media attachments found.' ); } - /** - * @param string $which - */ - protected function pagination( $which ) { - parent::pagination( $which ); - } - /** * Override parent views so we can use the filter bar display. */ diff --git a/src/wp-admin/includes/class-wp-upgrader-skins.php b/src/wp-admin/includes/class-wp-upgrader-skins.php index f8f5f5acde..6f34022069 100644 --- a/src/wp-admin/includes/class-wp-upgrader-skins.php +++ b/src/wp-admin/includes/class-wp-upgrader-skins.php @@ -317,10 +317,6 @@ class Bulk_Upgrader_Skin extends WP_Upgrader_Skin { class Bulk_Plugin_Upgrader_Skin extends Bulk_Upgrader_Skin { public $plugin_info = array(); // Plugin_Upgrader::bulk() will fill this in. - public function __construct($args = array()) { - parent::__construct($args); - } - public function add_strings() { parent::add_strings(); $this->upgrader->strings['skin_before_update_header'] = __('Updating Plugin %1$s (%2$d/%3$d)'); @@ -361,10 +357,6 @@ class Bulk_Plugin_Upgrader_Skin extends Bulk_Upgrader_Skin { class Bulk_Theme_Upgrader_Skin extends Bulk_Upgrader_Skin { public $theme_info = array(); // Theme_Upgrader::bulk() will fill this in. - public function __construct($args = array()) { - parent::__construct($args); - } - public function add_strings() { parent::add_strings(); $this->upgrader->strings['skin_before_update_header'] = __('Updating Theme %1$s (%2$d/%3$d)'); diff --git a/src/wp-includes/class-wp-customize-control.php b/src/wp-includes/class-wp-customize-control.php index b923da37c0..8e7a3c57c0 100644 --- a/src/wp-includes/class-wp-customize-control.php +++ b/src/wp-includes/class-wp-customize-control.php @@ -934,10 +934,6 @@ class WP_Customize_Header_Image_Control extends WP_Customize_Image_Control { } - public function to_json() { - parent::to_json(); - } - public function enqueue() { wp_enqueue_media(); wp_enqueue_script( 'customize-views' );