vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-05-31 16:40:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Consistently skip tests for non-implemented methods in REST API test classes.

Browse Source 
WordPress core test suite uses PHPUnit's `beStrictAboutTestsThatDoNotTestAnything` option set to `true`, which marks a test as risky when no assertions are performed.

REST API test classes have some empty tests for non-implemented methods because these test classes extend the abstract `WP_Test_REST_Controller_Testcase` class, which requires several methods to be implemented that don't necessarily make sense for all REST API routes.

Some of these empty tests were already marked as skipped, but not in a consistent manner. Since skipping these tests is intentional for the time being, this commit aims to bring some consistency and adjust them all to be more accurately reported as skipped instead of risky.

The skipping can be reconsidered in the future when the tests are either removed as unnecessary or updated to actually perform assertions related to their behavior.

Follow-up to [40534], [41176], [41228].

Props Mte90, tomepajk, johnbillion, zieladam, SergeyBiryukov.
See #40538, #41463, #55652.

git-svn-id: https://develop.svn.wordpress.org/trunk@53921 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2022-08-22 22:42:59 +00:00
parent 4bfbe07a89
commit 85ae9dd89b
18 changed files with 103 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/phpunit/tests/rest-api/rest-pattern-directory-controller.php
View File

@@ -311,19 +311,19 @@ class WP_REST_Pattern_Directory_Controller_Test extends WP_Test_REST_Controller_
}
public function test_get_item() {
$this->markTestSkipped( 'Controller does not have get_item route.' );
$this->markTestSkipped( 'Controller does not implement get_item().' );
}
public function test_create_item() {
$this->markTestSkipped( 'Controller does not have create_item route.' );
$this->markTestSkipped( 'Controller does not implement create_item().' );
}
public function test_update_item() {
$this->markTestSkipped( 'Controller does not have update_item route.' );
$this->markTestSkipped( 'Controller does not implement update_item().' );
}
public function test_delete_item() {
$this->markTestSkipped( 'Controller does not have delete_item route.' );
$this->markTestSkipped( 'Controller does not implement delete_item().' );
}
/**