vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Fix leakage in WP_List_Table tests.

Browse Source 
Fixes `WP_List_table` tests leaking into other tests by:

* Restores the original `$hook_suffix` global value.
Rather than modifying the global for all tests, it now restores the original value between tests. Why? To ensure each test starts at a known state.

* Uses a new instance of `WP_List_Table` for each test.
A test may modify the `$list_table` object. If it does, it could impact tests yet to run. By instantiating a new instance in the `set_up()` test fixture, each test is isolated from the others.

Follow-up to [53868], [54215].

Props hellofromTonya, antonvlasenko.
See #58955, #58896.

git-svn-id: https://develop.svn.wordpress.org/trunk@56348 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Tonya Mork 2023-08-02 17:58:18 +00:00
parent 02f9f1ea95
commit 88570fd5b3
1 changed files with 26 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
tests/phpunit/tests/admin/wpListTable.php
View File

@ -12,17 +12,34 @@ class Tests_Admin_WpListTable extends WP_UnitTestCase {
*
* @var WP_List_Table $list_table
*/
protected static $list_table;
private $list_table;
/**
* Original value of $GLOBALS['hook_suffix'].
*
* @var string
*/
private static $original_hook_suffix;
public static function set_up_before_class() {
global $hook_suffix;
parent::set_up_before_class();
require_once ABSPATH . 'wp-admin/includes/class-wp-list-table.php';
static::$original_hook_suffix = $GLOBALS['hook_suffix'];
require_once ABSPATH . 'wp-admin/includes/class-wp-list-table.php';
}
public function set_up() {
parent::set_up();
global $hook_suffix;
$hook_suffix = '_wp_tests';
self::$list_table = new WP_List_Table();
$this->list_table = new WP_List_Table();
}
public function clean_up_global_scope() {
global $hook_suffix;
$hook_suffix = static::$original_hook_suffix;
parent::clean_up_global_scope();
}
/**
@ -142,10 +159,10 @@ class Tests_Admin_WpListTable extends WP_UnitTestCase {
* @param array $expected
*/
public function test_get_views_links( $link_data, $expected ) {
$get_views_links = new ReflectionMethod( self::$list_table, 'get_views_links' );
$get_views_links = new ReflectionMethod( $this->list_table, 'get_views_links' );
$get_views_links->setAccessible( true );
$actual = $get_views_links->invokeArgs( self::$list_table, array( $link_data ) );
$actual = $get_views_links->invokeArgs( $this->list_table, array( $link_data ) );
$this->assertSameSetsWithIndex( $expected, $actual );
}
@ -257,9 +274,9 @@ class Tests_Admin_WpListTable extends WP_UnitTestCase {
* }
*/
public function test_get_views_links_doing_it_wrong( $link_data ) {
$get_views_links = new ReflectionMethod( self::$list_table, 'get_views_links' );
$get_views_links = new ReflectionMethod( $this->list_table, 'get_views_links' );
$get_views_links->setAccessible( true );
$get_views_links->invokeArgs( self::$list_table, array( $link_data ) );
$get_views_links->invokeArgs( $this->list_table, array( $link_data ) );
}
/**