From 8dc4b88fcfcf095a24e2aa41fa5c87291d2c5ecf Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Sun, 11 May 2014 07:02:05 +0000 Subject: [PATCH] In `wp.media.view.Settings::update()`, when handling checkboxes, check for a value of `'false'` in addition to casting `value` to boolean. `!! 'false'` evaluates to `true`. Props adamsilverstein. Fixes #23954. git-svn-id: https://develop.svn.wordpress.org/trunk@28371 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/js/media-views.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-includes/js/media-views.js b/src/wp-includes/js/media-views.js index 0d70ebf238..c732e4a595 100644 --- a/src/wp-includes/js/media-views.js +++ b/src/wp-includes/js/media-views.js @@ -5714,7 +5714,7 @@ } // Handle checkboxes. } else if ( $setting.is('input[type="checkbox"]') ) { - $setting.prop( 'checked', !! value ); + $setting.prop( 'checked', !! value && 'false' !== value ); } }, /**