Code is Poetry.

WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82

src/wp-includes/class-wp-post.php

@@ -17,7 +17,6 @@
  * @property-read array  $ancestors
  * @property-read int    $post_category
  * @property-read string $tag_input
- *
  */
 final class WP_Post {
 
@@ -243,8 +242,9 @@ final class WP_Post {
 		if ( ! $_post ) {
 			$_post = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->posts WHERE ID = %d LIMIT 1", $post_id ) );
 
-			if ( ! $_post )
+			if ( ! $_post ) {
 				return false;
+			}
 
 			$_post = sanitize_post( $_post, 'raw' );
 			wp_cache_add( $_post->ID, $_post, 'posts' );
@@ -263,8 +263,9 @@ final class WP_Post {
 	 * @param WP_Post|object $post Post object.
 	 */
 	public function __construct( $post ) {
-		foreach ( get_object_vars( $post ) as $key => $value )
+		foreach ( get_object_vars( $post ) as $key => $value ) {
 			$this->$key = $value;
+		}
 	}
 
 	/**
@@ -276,17 +277,21 @@ final class WP_Post {
 	 * @return bool
 	 */
 	public function __isset( $key ) {
-		if ( 'ancestors' == $key )
+		if ( 'ancestors' == $key ) {
 			return true;
+		}
 
-		if ( 'page_template' == $key )
+		if ( 'page_template' == $key ) {
 			return true;
+		}
 
-		if ( 'post_category' == $key )
+		if ( 'post_category' == $key ) {
 			return true;
+		}
 
-		if ( 'tags_input' == $key )
+		if ( 'tags_input' == $key ) {
 			return true;
+		}
 
 		return metadata_exists( 'post', $this->ID, $key );
 	}
@@ -305,33 +310,39 @@ final class WP_Post {
 		}
 
 		if ( 'post_category' == $key ) {
-			if ( is_object_in_taxonomy( $this->post_type, 'category' ) )
+			if ( is_object_in_taxonomy( $this->post_type, 'category' ) ) {
 				$terms = get_the_terms( $this, 'category' );
+			}
 
-			if ( empty( $terms ) )
+			if ( empty( $terms ) ) {
 				return array();
+			}
 
 			return wp_list_pluck( $terms, 'term_id' );
 		}
 
 		if ( 'tags_input' == $key ) {
-			if ( is_object_in_taxonomy( $this->post_type, 'post_tag' ) )
+			if ( is_object_in_taxonomy( $this->post_type, 'post_tag' ) ) {
 				$terms = get_the_terms( $this, 'post_tag' );
+			}
 
-			if ( empty( $terms ) )
+			if ( empty( $terms ) ) {
 				return array();
+			}
 
 			return wp_list_pluck( $terms, 'name' );
 		}
 
 		// Rest of the values need filtering.
-		if ( 'ancestors' == $key )
+		if ( 'ancestors' == $key ) {
 			$value = get_post_ancestors( $this );
-		else
+		} else {
 			$value = get_post_meta( $this->ID, $key, true );
+		}
 
-		if ( $this->filter )
+		if ( $this->filter ) {
 			$value = sanitize_post_field( $key, $value, $this->ID, $this->filter );
+		}
 
 		return $value;
 	}
@@ -345,11 +356,13 @@ final class WP_Post {
 	 * @return self|array|bool|object|WP_Post
 	 */
 	public function filter( $filter ) {
-		if ( $this->filter == $filter )
+		if ( $this->filter == $filter ) {
 			return $this;
+		}
 
-		if ( $filter == 'raw' )
+		if ( $filter == 'raw' ) {
 			return self::get_instance( $this->ID );
+		}
 
 		return sanitize_post( $this, $filter );
 	}
@@ -365,8 +378,9 @@ final class WP_Post {
 		$post = get_object_vars( $this );
 
 		foreach ( array( 'ancestors', 'page_template', 'post_category', 'tags_input' ) as $key ) {
-			if ( $this->__isset( $key ) )
+			if ( $this->__isset( $key ) ) {
 				$post[ $key ] = $this->__get( $key );
+			}
 		}
 
 		return $post;