Code is Poetry.

WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast
2017-11-30 23:09:33 +00:00
parent ec6a089f98
commit 8f95800d52
1103 changed files with 105978 additions and 78184 deletions
+162 -46
View File
@@ -84,7 +84,7 @@ class Tests_Pluggable extends WP_UnitTestCase {
'wp_upgrade',
'install_global_terms',
);
$test_files = array(
$test_files = array(
'wp-includes/pluggable.php',
);
@@ -97,7 +97,7 @@ class Tests_Pluggable extends WP_UnitTestCase {
foreach ( $test_functions as $function ) {
$data[] = array(
$function
$function,
);
}
@@ -106,7 +106,7 @@ class Tests_Pluggable extends WP_UnitTestCase {
foreach ( $functions[1] as $function ) {
$data[] = array(
$function
$function,
);
}
}
@@ -125,76 +125,192 @@ class Tests_Pluggable extends WP_UnitTestCase {
$signatures = array(
// wp-includes/pluggable.php:
'wp_set_current_user' => array( 'id', 'name' => '' ),
'wp_set_current_user' => array(
'id',
'name' => '',
),
'wp_get_current_user' => array(),
'get_userdata' => array( 'user_id' ),
'get_user_by' => array( 'field', 'value' ),
'cache_users' => array( 'user_ids' ),
'wp_mail' => array( 'to', 'subject', 'message', 'headers' => '', 'attachments' => array() ),
'wp_mail' => array(
'to',
'subject',
'message',
'headers' => '',
'attachments' => array(),
),
'wp_authenticate' => array( 'username', 'password' ),
'wp_logout' => array(),
'wp_validate_auth_cookie' => array( 'cookie' => '', 'scheme' => '' ),
'wp_generate_auth_cookie' => array( 'user_id', 'expiration', 'scheme' => 'auth', 'token' => '' ),
'wp_parse_auth_cookie' => array( 'cookie' => '', 'scheme' => '' ),
'wp_set_auth_cookie' => array( 'user_id', 'remember' => false, 'secure' => '', 'token' => '' ),
'wp_validate_auth_cookie' => array(
'cookie' => '',
'scheme' => '',
),
'wp_generate_auth_cookie' => array(
'user_id',
'expiration',
'scheme' => 'auth',
'token' => '',
),
'wp_parse_auth_cookie' => array(
'cookie' => '',
'scheme' => '',
),
'wp_set_auth_cookie' => array(
'user_id',
'remember' => false,
'secure' => '',
'token' => '',
),
'wp_clear_auth_cookie' => array(),
'is_user_logged_in' => array(),
'auth_redirect' => array(),
'check_admin_referer' => array( 'action' => -1, 'query_arg' => '_wpnonce' ),
'check_ajax_referer' => array( 'action' => -1, 'query_arg' => false, 'die' => true ),
'wp_redirect' => array( 'location', 'status' => 302 ),
'check_admin_referer' => array(
'action' => -1,
'query_arg' => '_wpnonce',
),
'check_ajax_referer' => array(
'action' => -1,
'query_arg' => false,
'die' => true,
),
'wp_redirect' => array(
'location',
'status' => 302,
),
'wp_sanitize_redirect' => array( 'location' ),
'_wp_sanitize_utf8_in_redirect' => array( 'matches' ),
'wp_safe_redirect' => array( 'location', 'status' => 302 ),
'wp_validate_redirect' => array( 'location', 'default' => '' ),
'wp_notify_postauthor' => array( 'comment_id', 'deprecated' => null ),
'wp_safe_redirect' => array(
'location',
'status' => 302,
),
'wp_validate_redirect' => array(
'location',
'default' => '',
),
'wp_notify_postauthor' => array(
'comment_id',
'deprecated' => null,
),
'wp_notify_moderator' => array( 'comment_id' ),
'wp_password_change_notification' => array( 'user' ),
'wp_new_user_notification' => array( 'user_id', 'deprecated' => null, 'notify' => '' ),
'wp_new_user_notification' => array(
'user_id',
'deprecated' => null,
'notify' => '',
),
'wp_nonce_tick' => array(),
'wp_verify_nonce' => array( 'nonce', 'action' => -1 ),
'wp_verify_nonce' => array(
'nonce',
'action' => -1,
),
'wp_create_nonce' => array( 'action' => -1 ),
'wp_salt' => array( 'scheme' => 'auth' ),
'wp_hash' => array( 'data', 'scheme' => 'auth' ),
'wp_hash' => array(
'data',
'scheme' => 'auth',
),
'wp_hash_password' => array( 'password' ),
'wp_check_password' => array( 'password', 'hash', 'user_id' => '' ),
'wp_generate_password' => array( 'length' => 12, 'special_chars' => true, 'extra_special_chars' => false ),
'wp_rand' => array( 'min' => 0, 'max' => 0 ),
'wp_check_password' => array(
'password',
'hash',
'user_id' => '',
),
'wp_generate_password' => array(
'length' => 12,
'special_chars' => true,
'extra_special_chars' => false,
),
'wp_rand' => array(
'min' => 0,
'max' => 0,
),
'wp_set_password' => array( 'password', 'user_id' ),
'get_avatar' => array( 'id_or_email', 'size' => 96, 'default' => '', 'alt' => '', 'args' => null ),
'wp_text_diff' => array( 'left_string', 'right_string', 'args' => null ),
'get_avatar' => array(
'id_or_email',
'size' => 96,
'default' => '',
'alt' => '',
'args' => null,
),
'wp_text_diff' => array(
'left_string',
'right_string',
'args' => null,
),
// wp-admin/includes/schema.php:
'install_network' => array(),
'install_network' => array(),
// wp-admin/includes/upgrade.php:
'wp_install' => array( 'blog_title', 'user_name', 'user_email', 'public', 'deprecated' => '', 'user_password' => '', 'language' => '' ),
'wp_install_defaults' => array( 'user_id' ),
'wp_new_blog_notification' => array( 'blog_title', 'blog_url', 'user_id', 'password' ),
'wp_upgrade' => array(),
'install_global_terms' => array(),
'wp_install' => array(
'blog_title',
'user_name',
'user_email',
'public',
'deprecated' => '',
'user_password' => '',
'language' => '',
),
'wp_install_defaults' => array( 'user_id' ),
'wp_new_blog_notification' => array( 'blog_title', 'blog_url', 'user_id', 'password' ),
'wp_upgrade' => array(),
'install_global_terms' => array(),
);
// Pluggable function signatures are not tested when an external object cache is in use. #31491
if ( ! wp_using_ext_object_cache() ) {
$signatures = array_merge( $signatures, array(
$signatures = array_merge(
$signatures, array(
// wp-includes/cache.php:
'wp_cache_add' => array( 'key', 'data', 'group' => '', 'expire' => 0 ),
'wp_cache_close' => array(),
'wp_cache_decr' => array( 'key', 'offset' => 1, 'group' => '' ),
'wp_cache_delete' => array( 'key', 'group' => '' ),
'wp_cache_flush' => array(),
'wp_cache_get' => array( 'key', 'group' => '', 'force' => false, 'found' => null ),
'wp_cache_incr' => array( 'key', 'offset' => 1, 'group' => '' ),
'wp_cache_init' => array(),
'wp_cache_replace' => array( 'key', 'data', 'group' => '', 'expire' => 0 ),
'wp_cache_set' => array( 'key', 'data', 'group' => '', 'expire' => 0 ),
'wp_cache_switch_to_blog' => array( 'blog_id' ),
'wp_cache_add_global_groups' => array( 'groups' ),
'wp_cache_add_non_persistent_groups' => array( 'groups' ),
'wp_cache_reset' => array(),
) );
// wp-includes/cache.php:
'wp_cache_add' => array(
'key',
'data',
'group' => '',
'expire' => 0,
),
'wp_cache_close' => array(),
'wp_cache_decr' => array(
'key',
'offset' => 1,
'group' => '',
),
'wp_cache_delete' => array(
'key',
'group' => '',
),
'wp_cache_flush' => array(),
'wp_cache_get' => array(
'key',
'group' => '',
'force' => false,
'found' => null,
),
'wp_cache_incr' => array(
'key',
'offset' => 1,
'group' => '',
),
'wp_cache_init' => array(),
'wp_cache_replace' => array(
'key',
'data',
'group' => '',
'expire' => 0,
),
'wp_cache_set' => array(
'key',
'data',
'group' => '',
'expire' => 0,
),
'wp_cache_switch_to_blog' => array( 'blog_id' ),
'wp_cache_add_global_groups' => array( 'groups' ),
'wp_cache_add_non_persistent_groups' => array( 'groups' ),
'wp_cache_reset' => array(),
)
);
}
return $signatures;