Code is Poetry.

WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.



git-svn-id: https://develop.svn.wordpress.org/trunk@42343 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast
2017-11-30 23:09:33 +00:00
parent ec6a089f98
commit 8f95800d52
1103 changed files with 105981 additions and 78187 deletions

View File

@@ -6,57 +6,75 @@
*/
class Tests_Post_GetPosts extends WP_UnitTestCase {
public function test_offset_should_be_null_by_default() {
$p1 = self::factory()->post->create( array(
'post_date' => '2015-04-04 04:04:04',
) );
$p2 = self::factory()->post->create( array(
'post_date' => '2014-04-04 04:04:04',
) );
$p1 = self::factory()->post->create(
array(
'post_date' => '2015-04-04 04:04:04',
)
);
$p2 = self::factory()->post->create(
array(
'post_date' => '2014-04-04 04:04:04',
)
);
$found = get_posts( array(
'numberposts' => 1,
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
) );
$found = get_posts(
array(
'numberposts' => 1,
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
)
);
$this->assertSame( array( $p1 ), $found );
}
public function test_offset_0_should_be_respected() {
$p1 = self::factory()->post->create( array(
'post_date' => '2015-04-04 04:04:04',
) );
$p2 = self::factory()->post->create( array(
'post_date' => '2014-04-04 04:04:04',
) );
$p1 = self::factory()->post->create(
array(
'post_date' => '2015-04-04 04:04:04',
)
);
$p2 = self::factory()->post->create(
array(
'post_date' => '2014-04-04 04:04:04',
)
);
$found = get_posts( array(
'numberposts' => 1,
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'offset' => 0,
) );
$found = get_posts(
array(
'numberposts' => 1,
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'offset' => 0,
)
);
$this->assertSame( array( $p1 ), $found );
}
public function test_offset_non_0_should_be_respected() {
$p1 = self::factory()->post->create( array(
'post_date' => '2015-04-04 04:04:04',
) );
$p2 = self::factory()->post->create( array(
'post_date' => '2014-04-04 04:04:04',
) );
$p1 = self::factory()->post->create(
array(
'post_date' => '2015-04-04 04:04:04',
)
);
$p2 = self::factory()->post->create(
array(
'post_date' => '2014-04-04 04:04:04',
)
);
$found = get_posts( array(
'numberposts' => 1,
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'offset' => 1,
) );
$found = get_posts(
array(
'numberposts' => 1,
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'offset' => 1,
)
);
$this->assertSame( array( $p2 ), $found );
}
@@ -65,63 +83,83 @@ class Tests_Post_GetPosts extends WP_UnitTestCase {
* @ticket 34060
*/
public function test_paged_should_not_be_overridden_by_default_offset() {
$p1 = self::factory()->post->create( array(
'post_date' => '2015-04-04 04:04:04',
) );
$p2 = self::factory()->post->create( array(
'post_date' => '2014-04-04 04:04:04',
) );
$p1 = self::factory()->post->create(
array(
'post_date' => '2015-04-04 04:04:04',
)
);
$p2 = self::factory()->post->create(
array(
'post_date' => '2014-04-04 04:04:04',
)
);
$found = get_posts( array(
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'paged' => 2,
'posts_per_page' => 1,
) );
$found = get_posts(
array(
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'paged' => 2,
'posts_per_page' => 1,
)
);
$this->assertSame( array( $p2 ), $found );
}
public function test_explicit_offset_0_should_override_paged() {
$p1 = self::factory()->post->create( array(
'post_date' => '2015-04-04 04:04:04',
) );
$p2 = self::factory()->post->create( array(
'post_date' => '2014-04-04 04:04:04',
) );
$p1 = self::factory()->post->create(
array(
'post_date' => '2015-04-04 04:04:04',
)
);
$p2 = self::factory()->post->create(
array(
'post_date' => '2014-04-04 04:04:04',
)
);
$found = get_posts( array(
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'paged' => 2,
'posts_per_page' => 1,
'offset' => 0,
) );
$found = get_posts(
array(
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'paged' => 2,
'posts_per_page' => 1,
'offset' => 0,
)
);
$this->assertSame( array( $p1 ), $found );
}
public function test_explicit_offset_non_0_should_override_paged() {
$p1 = self::factory()->post->create( array(
'post_date' => '2015-04-04 04:04:04',
) );
$p2 = self::factory()->post->create( array(
'post_date' => '2014-04-04 04:04:04',
) );
$p3 = self::factory()->post->create( array(
'post_date' => '2013-04-04 04:04:04',
) );
$p1 = self::factory()->post->create(
array(
'post_date' => '2015-04-04 04:04:04',
)
);
$p2 = self::factory()->post->create(
array(
'post_date' => '2014-04-04 04:04:04',
)
);
$p3 = self::factory()->post->create(
array(
'post_date' => '2013-04-04 04:04:04',
)
);
$found = get_posts( array(
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'paged' => 2,
'posts_per_page' => 1,
'offset' => 2,
) );
$found = get_posts(
array(
'orderby' => 'date',
'order' => 'DESC',
'fields' => 'ids',
'paged' => 2,
'posts_per_page' => 1,
'offset' => 2,
)
);
$this->assertSame( array( $p3 ), $found );
}