vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Use assertSame() in get_comment_pages_count() tests.

Browse Source 
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [27055], [48937], [54402], [57244], [57648].

Props costdev.
See #58683, #59655.

git-svn-id: https://develop.svn.wordpress.org/trunk@57650 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2024-02-17 16:32:37 +00:00
parent 55a14eae8b
commit 8fc144ab27
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
tests/phpunit/tests/comment/getCommentsPagesCount.php
View File

@ -78,9 +78,9 @@ class Tests_Comment_GetCommentsPagesCount extends WP_UnitTestCase {
self::factory()->comment->create_post_comments( $post->ID, 6, array( 'comment_parent' => $comments[0] ) );
$comments = get_comments( array( 'post_id' => $post->ID ) );
$this->assertEquals( 3, get_comment_pages_count( $comments, 10, false ) );
$this->assertEquals( 2, get_comment_pages_count( $comments, 10, true ) );
$this->assertEquals( 4, get_comment_pages_count( $comments, 4, true ) );
$this->assertSame( 3, get_comment_pages_count( $comments, 10, false ) );
$this->assertSame( 2, get_comment_pages_count( $comments, 10, true ) );
$this->assertSame( 4, get_comment_pages_count( $comments, 4, true ) );
}
/**
@ -101,17 +101,17 @@ class Tests_Comment_GetCommentsPagesCount extends WP_UnitTestCase {
update_option( 'thread_comments', false );
$this->assertEquals( 3, get_comment_pages_count( $comments, 10, false ) );
$this->assertEquals( 2, get_comment_pages_count( $comments, 10, true ) );
$this->assertEquals( 3, get_comment_pages_count( $comments, 10, null ) );
$this->assertEquals( 3, get_comment_pages_count( $comments, 10 ) );
$this->assertSame( 3, get_comment_pages_count( $comments, 10, false ) );
$this->assertSame( 2, get_comment_pages_count( $comments, 10, true ) );
$this->assertSame( 3, get_comment_pages_count( $comments, 10, null ) );
$this->assertSame( 3, get_comment_pages_count( $comments, 10 ) );
update_option( 'thread_comments', true );
$this->assertEquals( 3, get_comment_pages_count( $comments, 10, false ) );
$this->assertEquals( 2, get_comment_pages_count( $comments, 10, true ) );
$this->assertEquals( 2, get_comment_pages_count( $comments, 10, null ) );
$this->assertEquals( 2, get_comment_pages_count( $comments, 10 ) );
$this->assertSame( 3, get_comment_pages_count( $comments, 10, false ) );
$this->assertSame( 2, get_comment_pages_count( $comments, 10, true ) );
$this->assertSame( 2, get_comment_pages_count( $comments, 10, null ) );
$this->assertSame( 2, get_comment_pages_count( $comments, 10 ) );
}
/**
@ -140,8 +140,8 @@ class Tests_Comment_GetCommentsPagesCount extends WP_UnitTestCase {
update_option( 'comments_per_page', 25 );
$this->assertEquals( 3, get_comment_pages_count() );
$this->assertEquals( 2, get_comment_pages_count( null, 20 ) );
$this->assertSame( 3, get_comment_pages_count() );
$this->assertSame( 2, get_comment_pages_count( null, 20 ) );
$wp_query = new WP_Query(
array(
@ -151,16 +151,16 @@ class Tests_Comment_GetCommentsPagesCount extends WP_UnitTestCase {
)
);
$this->assertEquals( 1, get_comment_pages_count() );
$this->assertEquals( 5, get_comment_pages_count( null, 5 ) );
$this->assertSame( 1, get_comment_pages_count() );
$this->assertSame( 5, get_comment_pages_count( null, 5 ) );
$wp_query->query_vars['comments_per_page'] = null;
update_option( 'comments_per_page', 5 );
$this->assertEquals( 5, get_comment_pages_count() );
$this->assertEquals( 3, get_comment_pages_count( null, 11 ) );
$this->assertEquals( 5, get_comment_pages_count( null, 0 ) );
$this->assertSame( 5, get_comment_pages_count() );
$this->assertSame( 3, get_comment_pages_count( null, 11 ) );
$this->assertSame( 5, get_comment_pages_count( null, 0 ) );
}
/**