vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-03-31 18:54:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Query: Restore late compact() call for the posts_clauses_request filter.

Browse Source 
This addresses a backward compatibility break where `posts_join_request` and other filters were applied, but their results were subsequently discarded and earlier values were used instead.

Follow-up to [52974], [53175].

Props 5um17, johnbillion, SergeyBiryukov.
Fixes #55699.

git-svn-id: https://develop.svn.wordpress.org/trunk@53370 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2022-05-09 13:49:29 +00:00
parent a6eec99e46
commit 90f953603b
2 changed files with 55 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/wp-includes/class-wp-query.php
View File

@@ -2754,8 +2754,6 @@ class WP_Query {
}
}
$clauses = array( 'where', 'groupby', 'join', 'orderby', 'distinct', 'fields', 'limits' );
/*
* Apply post-paging filters on where and join. Only plugins that
* manipulate paging queries should use these hooks.
@@ -2835,6 +2833,8 @@ class WP_Query {
*/
$fields = apply_filters_ref_array( 'posts_fields', array( $fields, &$this ) );
$clauses = array( 'where', 'groupby', 'join', 'orderby', 'distinct', 'fields', 'limits' );
/**
* Filters all query clauses at once, for convenience.
*
@@ -2967,6 +2967,8 @@ class WP_Query {
*/
$limits = apply_filters_ref_array( 'post_limits_request', array( $limits, &$this ) );
$clauses = array( 'where', 'groupby', 'join', 'orderby', 'distinct', 'fields', 'limits' );
/**
* Filters all query clauses at once, for convenience.
*
@@ -2990,7 +2992,7 @@ class WP_Query {
* }
* @param WP_Query $query The WP_Query instance (passed by reference).
*/
$clauses = (array) apply_filters_ref_array( 'posts_clauses_request', array( $clauses, &$this ) );
$clauses = (array) apply_filters_ref_array( 'posts_clauses_request', array( compact( $clauses ), &$this ) );
$where = isset( $clauses['where'] ) ? $clauses['where'] : '';
$groupby = isset( $clauses['groupby'] ) ? $clauses['groupby'] : '';