vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-03-31 18:54:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Query: Restore late compact() call for the posts_clauses_request filter.

Browse Source 
This addresses a backward compatibility break where `posts_join_request` and other filters were applied, but their results were subsequently discarded and earlier values were used instead.

Follow-up to [52974], [53175].

Props 5um17, johnbillion, SergeyBiryukov.
Fixes #55699.

git-svn-id: https://develop.svn.wordpress.org/trunk@53370 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2022-05-09 13:49:29 +00:00
parent a6eec99e46
commit 90f953603b
2 changed files with 55 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
tests/phpunit/tests/query.php
View File

@@ -719,4 +719,54 @@ class Tests_Query extends WP_UnitTestCase {
$this->assertInstanceOf( 'WP_User', get_queried_object() );
$this->assertSame( get_queried_object_id(), $user_id );
}
/**
* Tests that the `posts_clauses` filter receives an array of clauses
* with the other `posts_*` filters applied, e.g. `posts_join_paged`.
*
* @ticket 55699
* @covers WP_Query::get_posts
*/
public function test_posts_clauses_filter_should_receive_filtered_clauses() {
add_filter(
'posts_join_paged',
static function() {
return '/* posts_join_paged */';
}
);
$filter = new MockAction();
add_filter( 'posts_clauses', array( $filter, 'filter' ), 10, 2 );
$this->go_to( '/' );
$filter_args = $filter->get_args();
$posts_clauses = $filter_args[0][0];
$this->assertArrayHasKey( 'join', $posts_clauses );
$this->assertSame( '/* posts_join_paged */', $posts_clauses['join'] );
}
/**
* Tests that the `posts_clauses_request` filter receives an array of clauses
* with the other `posts_*_request` filters applied, e.g. `posts_join_request`.
*
* @ticket 55699
* @covers WP_Query::get_posts
*/
public function test_posts_clauses_request_filter_should_receive_filtered_clauses() {
add_filter(
'posts_join_request',
static function() {
return '/* posts_join_request */';
}
);
$filter = new MockAction();
add_filter( 'posts_clauses_request', array( $filter, 'filter' ), 10, 2 );
$this->go_to( '/' );
$filter_args = $filter->get_args();
$posts_clauses_request = $filter_args[0][0];
$this->assertArrayHasKey( 'join', $posts_clauses_request );
$this->assertSame( '/* posts_join_request */', $posts_clauses_request['join'] );
}
}