vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-04 20:54:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Toolbar: Use add_node() instead of add_menu() in core.

Browse Source 
This patch replaces all references to the add_menu() method with the add_node() one. (Also some code structure modifications for wp_admin_bar_appearance_menu().)

Fixes: #19647
Props: linuxologos, paulschreiber, morganestes, akibjorklund, nacin, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46642 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jake Spurlock
2019-11-03 22:12:32 +00:00
parent 40946e984a
commit 922721c360
4 changed files with 84 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/phpunit/tests/adminbar.php
View File

@@ -345,6 +345,26 @@ class Tests_AdminBar extends WP_UnitTestCase {
);
}
/**
* @ticket 19647
*/
public function test_deprecated_menu_methods() {
$admin_bar = new WP_Admin_Bar();
$node_data = array( 'id' => 'test-node-19647' );
// Test add_menu() deprecation.
$this->setExpectedDeprecated( 'WP_Admin_Bar::add_menu' );
$admin_bar->add_menu( $node_data );
$node_test = $admin_bar->get_node( 'test-node-19647' );
$this->assertNotNull( $node_test );
// Test remove_menu() deprecation.
$this->setExpectedDeprecated( 'WP_Admin_Bar::remove_menu' );
$admin_bar->remove_menu( 'test-node-19647' );
$node_test = $admin_bar->get_node( 'test-node-19647' );
$this->assertNull( $node_test );
}
/**
* @ticket 22247
*/