vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 12:20:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Store only term IDs in object term relationships caches.

Browse Source 
Previously, objects containing all data about a term were stored in each
object's term cache. Besides being wasteful, this approach caused invalidation
issues, as when a modified term count required a flush for all objects
belonging to the term.

Backward compatibility is maintained for plugins that continue to put object
data directly into the `{$taxonomy}_relationships` cache bucket.

Fixes #36814.

git-svn-id: https://develop.svn.wordpress.org/trunk@37573 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2016-05-26 04:49:10 +00:00
parent 8b9bdaccd2
commit 96b71d7d89
5 changed files with 110 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/term/getTheTerms.php
+46 -19
View File
@@ -75,25 +75,6 @@ class Tests_Term_GetTheTerms extends WP_UnitTestCase {
$this->assertEquals( 'This description is even more amazing!', $terms[0]->description );
}
/**
* @ticket 34262
*/
public function test_get_the_terms_should_not_cache_wp_term_objects() {
$p = self::$post_ids[0];
register_taxonomy( 'wptests_tax', 'post' );
$t = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax' ) );
wp_set_object_terms( $p, $t, 'wptests_tax' );
// Prime the cache.
$terms = get_the_terms( $p, 'wptests_tax' );
$cached = get_object_term_cache( $p, 'wptests_tax' );
$this->assertNotEmpty( $cached );
$this->assertSame( $t, (int) $cached[0]->term_id );
$this->assertNotInstanceOf( 'WP_Term', $cached[0] );
}
/**
* @ticket 34262
*/
@@ -170,4 +151,50 @@ class Tests_Term_GetTheTerms extends WP_UnitTestCase {
$terms = get_the_terms( $p, 'this-taxonomy-does-not-exist' );
$this->assertTrue( is_wp_error( $terms ) );
}
/**
* @ticket 36814
*/
public function test_count_should_not_be_improperly_cached() {
register_taxonomy( 'wptests_tax', 'post' );
$t = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax' ) );
wp_set_object_terms( self::$post_ids[0], $t, 'wptests_tax' );
$terms = get_the_terms( self::$post_ids[0], 'wptests_tax' );
$this->assertSame( 1, $terms[0]->count );
wp_set_object_terms( self::$post_ids[1], $t, 'wptests_tax' );
$terms = get_the_terms( self::$post_ids[0], 'wptests_tax' );
$this->assertSame( 2, $terms[0]->count );
}
/**
* @ticket 36814
*/
public function test_uncached_terms_should_be_primed_with_a_single_query() {
global $wpdb;
register_taxonomy( 'wptests_tax', 'post' );
$terms = self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
wp_set_object_terms( self::$post_ids[0], $terms, 'wptests_tax' );
get_the_terms( self::$post_ids[0], 'wptests_tax' );
// Clean cache for two of the terms.
clean_term_cache( array( $terms[0], $terms[1] ), 'wptests_tax', false );
$num_queries = $wpdb->num_queries;
$found = get_the_terms( self::$post_ids[0], 'wptests_tax' );
$this->assertEqualSets( $terms, wp_list_pluck( $found, 'term_id' ) );
$num_queries++;
$this->assertSame( $num_queries, $wpdb->num_queries );
}
}