diff --git a/src/wp-includes/option.php b/src/wp-includes/option.php index ec41b060ae..dc2195949f 100644 --- a/src/wp-includes/option.php +++ b/src/wp-includes/option.php @@ -77,7 +77,10 @@ function get_option( $option, $default = false ) { global $wpdb; - $option = trim( $option ); + if ( is_scalar( $option ) ) { + $option = trim( $option ); + } + if ( empty( $option ) ) { return false; } @@ -378,7 +381,10 @@ function wp_load_core_site_options( $network_id = null ) { function update_option( $option, $value, $autoload = null ) { global $wpdb; - $option = trim( $option ); + if ( is_scalar( $option ) ) { + $option = trim( $option ); + } + if ( empty( $option ) ) { return false; } @@ -565,7 +571,10 @@ function add_option( $option, $value = '', $deprecated = '', $autoload = 'yes' ) _deprecated_argument( __FUNCTION__, '2.3.0' ); } - $option = trim( $option ); + if ( is_scalar( $option ) ) { + $option = trim( $option ); + } + if ( empty( $option ) ) { return false; } @@ -687,7 +696,10 @@ function add_option( $option, $value = '', $deprecated = '', $autoload = 'yes' ) function delete_option( $option ) { global $wpdb; - $option = trim( $option ); + if ( is_scalar( $option ) ) { + $option = trim( $option ); + } + if ( empty( $option ) ) { return false; } diff --git a/tests/phpunit/tests/option/option.php b/tests/phpunit/tests/option/option.php index 79331f9a24..a2145f1c18 100644 --- a/tests/phpunit/tests/option/option.php +++ b/tests/phpunit/tests/option/option.php @@ -148,6 +148,66 @@ class Tests_Option_Option extends WP_UnitTestCase { ); } + /** + * @ticket 53635 + * + * @dataProvider data_valid_but_undesired_option_names + * + * @param mixed $option_name Option name. + */ + public function test_get_option_valid_but_undesired_option_names( $option_name ) { + $this->assertFalse( get_option( $option_name ) ); + } + + /** + * @ticket 53635 + * + * @dataProvider data_valid_but_undesired_option_names + * + * @param mixed $option_name Option name. + */ + public function test_add_option_valid_but_undesired_option_names( $option_name ) { + $this->assertTrue( add_option( $option_name, '' ) ); + } + + /** + * @ticket 53635 + * + * @dataProvider data_valid_but_undesired_option_names + * + * @param mixed $option_name Option name. + */ + public function test_update_option_valid_but_undesired_option_names( $option_name ) { + $this->assertTrue( update_option( $option_name, '' ) ); + } + + /** + * @ticket 53635 + * + * @dataProvider data_valid_but_undesired_option_names + * + * @param mixed $option_name Option name. + */ + public function test_delete_option_valid_but_undesired_option_names( $option_name ) { + $this->assertFalse( delete_option( $option_name ) ); + } + + /** + * Data provider. + * + * @return array + */ + public function data_valid_but_undesired_option_names() { + return array( + 'string 123' => array( '123' ), + 'integer 123' => array( 123 ), + 'integer -123' => array( -123 ), + 'float 12.3' => array( 12.3 ), + 'float -1.23' => array( -1.23 ), + 'boolean true' => array( true ), + ); + } + /** * @ticket 23289 */