From 9b6a3ecfcf4a448d2cdc4f4e2b342beac3d485c8 Mon Sep 17 00:00:00 2001 From: Jb Audras Date: Thu, 15 Sep 2022 12:27:02 +0000 Subject: [PATCH] Help/About: Remove `.hidden` class when the Help Tab panel is displayed. It is obviously more logical and semantic to remove the `hidden` class when the panel is displayed. Plus, it prevents from weird behavior occurring when plugins also use the `hidden` class to hide stuff. Props grabmedia, SergeyBiryukov, helen, sabernhardt, costdev, audrasjb. Fixes #27697. git-svn-id: https://develop.svn.wordpress.org/trunk@54177 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/_enqueues/admin/common.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/js/_enqueues/admin/common.js b/src/js/_enqueues/admin/common.js index 8ea548e642..1f9e6e454e 100644 --- a/src/js/_enqueues/admin/common.js +++ b/src/js/_enqueues/admin/common.js @@ -617,7 +617,7 @@ window.screenMeta = { * @return {void} */ panel.slideDown( 'fast', function() { - panel.trigger( 'focus' ); + panel.removeClass( 'hidden' ).trigger( 'focus' ); button.addClass( 'screen-meta-active' ).attr( 'aria-expanded', true ); }); @@ -646,6 +646,7 @@ window.screenMeta = { button.removeClass( 'screen-meta-active' ).attr( 'aria-expanded', false ); $('.screen-meta-toggle').css('visibility', ''); panel.parent().hide(); + panel.addClass( 'hidden' ); }); $document.trigger( 'screen:options:close' );