vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-04 06:37:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Widgets: Remove the title attributes used in the Tag cloud widget.

Browse Source 
- improves accessibility using an aria-label attribute to match the information conveyed visually with the one exposed to assistive technologies
- adds an option in the widget to display the item counts, consistently with what other widgets already do (Archives, Categories)

Props adamsoucie, emirpprime, Samantha Miller., MikeLittle, rianrietveld, sami.keijonen, adamsilverstein, westonruter, afercia.
See #24766.
Fixes #35566.


git-svn-id: https://develop.svn.wordpress.org/trunk@40816 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrea Fercia
2017-05-22 20:23:49 +00:00
parent 5ea3c91d57
commit 9e969efb89
4 changed files with 86 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wp-includes/widgets/class-wp-widget-tag-cloud.php
+19 -5
View File
@@ -53,6 +53,8 @@ class WP_Widget_Tag_Cloud extends WP_Widget {
}
}
$show_count = ! empty( $instance['count'] );
/**
* Filters the taxonomy used in the Tag Cloud widget.
*
@@ -64,8 +66,9 @@ class WP_Widget_Tag_Cloud extends WP_Widget {
* @param array $args Args used for the tag cloud widget.
*/
$tag_cloud = wp_tag_cloud( apply_filters( 'widget_tag_cloud_args', array(
'taxonomy' => $current_taxonomy,
'echo' => false
'taxonomy' => $current_taxonomy,
'echo' => false,
'show_count' => $show_count,
) ) );
if ( empty( $tag_cloud ) ) {
@@ -102,6 +105,7 @@ class WP_Widget_Tag_Cloud extends WP_Widget {
public function update( $new_instance, $old_instance ) {
$instance = array();
$instance['title'] = sanitize_text_field( $new_instance['title'] );
$instance['count'] = ! empty( $new_instance['count'] ) ? 1 : 0;
$instance['taxonomy'] = stripslashes($new_instance['taxonomy']);
return $instance;
}
@@ -117,6 +121,7 @@ class WP_Widget_Tag_Cloud extends WP_Widget {
public function form( $instance ) {
$current_taxonomy = $this->_get_current_taxonomy($instance);
$title_id = $this->get_field_id( 'title' );
$count = isset( $instance['count'] ) ? (bool) $instance['count'] : false;
$instance['title'] = ! empty( $instance['title'] ) ? esc_attr( $instance['title'] ) : '';
echo '<p><label for="' . $title_id .'">' . __( 'Title:' ) . '</label>
@@ -128,6 +133,14 @@ class WP_Widget_Tag_Cloud extends WP_Widget {
$name = $this->get_field_name( 'taxonomy' );
$input = '<input type="hidden" id="' . $id . '" name="' . $name . '" value="%s" />';
$count_checkbox = sprintf(
'<p><input type="checkbox" class="checkbox" id="%1$s" name="%2$s"%3$s /> <label for="%1$s">%4$s</label></p>',
$this->get_field_id( 'count' ),
$this->get_field_name( 'count' ),
checked( $count, true, false ),
__( 'Show tag counts' )
);
switch ( count( $taxonomies ) ) {
// No tag cloud supporting taxonomies found, display error message
@@ -136,14 +149,15 @@ class WP_Widget_Tag_Cloud extends WP_Widget {
printf( $input, '' );
break;
// Just a single tag cloud supporting taxonomy found, no need to display options
// Just a single tag cloud supporting taxonomy found, no need to display a select.
case 1:
$keys = array_keys( $taxonomies );
$taxonomy = reset( $keys );
printf( $input, esc_attr( $taxonomy ) );
echo $count_checkbox;
break;
// More than one tag cloud supporting taxonomy found, display options
// More than one tag cloud supporting taxonomy found, display a select.
default:
printf(
'<p><label for="%1$s">%2$s</label>' .
@@ -162,7 +176,7 @@ class WP_Widget_Tag_Cloud extends WP_Widget {
);
}
echo '</select></p>';
echo '</select></p>' . $count_checkbox;
}
}