vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Add a unit test for WP_Object_Cache::is_valid_key().

Browse Source 
A valid cache key for `wp_cache_*()` functions must be either an integer number or a non-empty string.

Follow-up to [53818].

See #56198.

git-svn-id: https://develop.svn.wordpress.org/trunk@53821 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2022-08-04 12:09:03 +00:00
parent e6f7520266
commit a164d64275
1 changed files with 43 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
tests/phpunit/tests/cache.php
View File

@ -26,6 +26,48 @@ class Tests_Cache extends WP_UnitTestCase {
return $cache;
}
/**
* @ticket 56198
*
* @covers WP_Object_Cache::is_valid_key
* @dataProvider data_is_valid_key
*/
public function test_is_valid_key( $key, $valid ) {
if ( wp_using_ext_object_cache() ) {
$this->markTestSkipped( 'This test requires that an external object cache is not in use.' );
}
$val = 'val';
if ( $valid ) {
$this->assertTrue( $this->cache->add( $key, $val ), 'WP_Object_Cache:add() should return true for valid keys.' );
$this->assertSame( $val, $this->cache->get( $key ), 'The retrieved value should match the added value.' );
} else {
$this->setExpectedIncorrectUsage( 'WP_Object_Cache::add' );
$this->assertFalse( $this->cache->add( $key, $val ), 'WP_Object_Cache:add() should return false for invalid keys.' );
}
}
/**
* Data provider for test_is_valid_key().
*
* @return array[] Test parameters {
* @type mixed $key Cache key value.
* @type bool $valid Whether the key should be considered valid.
* }
*/
public function data_is_valid_key() {
return array(
array( false, false ),
array( null, false ),
array( '', false ),
array( 0, true ),
array( 1, true ),
array( '0', true ),
array( 'key', true ),
);
}
public function test_miss() {
$this->assertFalse( $this->cache->get( 'test_miss' ) );
}
@ -112,9 +154,7 @@ class Tests_Cache extends WP_UnitTestCase {
}
public function test_flush() {
global $_wp_using_ext_object_cache;
if ( $_wp_using_ext_object_cache ) {
if ( wp_using_ext_object_cache() ) {
$this->markTestSkipped( 'This test requires that an external object cache is not in use.' );
}