vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Toolbar: Un-deprecate the WP_Admin_Bar::add_menu() method.

Browse Source 
This is only a wrapper for the `add_node()` method, but it's in widespread use both in core until [46642] and in thousands of plugins and themes. Deprecating it would have made sense when #19647 was originally opened but that's no longer the case.

Props whyisjake

Fixes #19647 


git-svn-id: https://develop.svn.wordpress.org/trunk@46678 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
John Blackbourn
2019-11-08 13:17:35 +00:00
parent 698aa0e564
commit a216b6d838
2 changed files with 0 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/phpunit/tests/adminbar.php
View File

@@ -345,26 +345,6 @@ class Tests_AdminBar extends WP_UnitTestCase {
);
}
/**
* @ticket 19647
*/
public function test_deprecated_menu_methods() {
$admin_bar = new WP_Admin_Bar();
$node_data = array( 'id' => 'test-node-19647' );
// Test add_menu() deprecation.
$this->setExpectedDeprecated( 'WP_Admin_Bar::add_menu' );
$admin_bar->add_menu( $node_data );
$node_test = $admin_bar->get_node( 'test-node-19647' );
$this->assertNotNull( $node_test );
// Test remove_menu() deprecation.
$this->setExpectedDeprecated( 'WP_Admin_Bar::remove_menu' );
$admin_bar->remove_menu( 'test-node-19647' );
$node_test = $admin_bar->get_node( 'test-node-19647' );
$this->assertNull( $node_test );
}
/**
* @ticket 22247
*/