From a69c9ff66f22737066b8c73a31d11ee76046ba81 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 26 Aug 2015 15:22:57 +0000 Subject: [PATCH] Make post meta box toggles accessible. props joedolson. fixes #33544. git-svn-id: https://develop.svn.wordpress.org/trunk@33762 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/css/common.css | 4 ++-- src/wp-admin/includes/template.php | 7 +++++-- src/wp-admin/js/postbox.js | 7 +++++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/wp-admin/css/common.css b/src/wp-admin/css/common.css index d3765d9d02..c1abe00edd 100644 --- a/src/wp-admin/css/common.css +++ b/src/wp-admin/css/common.css @@ -1788,8 +1788,8 @@ html.wp-toolbar { .postbox .handlediv { float: right; - width: 27px; - height: 30px; + width: 33px; + height: 36px; } .js .postbox .handlediv { diff --git a/src/wp-admin/includes/template.php b/src/wp-admin/includes/template.php index 0e44c6139d..abab6dfd37 100644 --- a/src/wp-admin/includes/template.php +++ b/src/wp-admin/includes/template.php @@ -1083,8 +1083,11 @@ function do_meta_boxes( $screen, $context, $object ) { $i++; $hidden_class = in_array($box['id'], $hidden) ? ' hide-if-js' : ''; echo '
' . "\n"; - if ( 'dashboard_browser_nag' != $box['id'] ) - echo '

'; + if ( 'dashboard_browser_nag' != $box['id'] ) { + echo ''; + } echo "

{$box['title']}

\n"; echo '
' . "\n"; call_user_func($box['callback'], $object, $box); diff --git a/src/wp-admin/js/postbox.js b/src/wp-admin/js/postbox.js index 07e5ed25b3..bee20cbc03 100644 --- a/src/wp-admin/js/postbox.js +++ b/src/wp-admin/js/postbox.js @@ -11,13 +11,16 @@ var postboxes; self.init(page, args); - $('.postbox .hndle, .postbox .handlediv').bind('click.postboxes', function() { + $('.postbox .hndle, .postbox .handlediv').bind('click.postboxes', function( e ) { var p = $(this).parent('.postbox'), id = p.attr('id'); if ( 'dashboard_browser_nag' == id ) return; - p.toggleClass('closed'); + e.preventDefault(); + + p.toggleClass( 'closed' ); + $(this).attr( 'aria-expanded', ! p.hasClass( 'closed' ) ); if ( page != 'press-this' ) self.save_state(page);