mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2026-04-01 11:14:36 +00:00
Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues. This change includes three notable additions: - Multiline function calls must now put each parameter on a new line. - Auto-formatting files is now part of the `grunt precommit` script. - Auto-fixable coding standards issues will now cause Travis failures. Fixes #44600. git-svn-id: https://develop.svn.wordpress.org/trunk@43571 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
@@ -39,13 +39,15 @@ function _wp_scripts_maybe_doing_it_wrong( $function ) {
|
||||
}
|
||||
|
||||
_doing_it_wrong(
|
||||
$function, sprintf(
|
||||
$function,
|
||||
sprintf(
|
||||
/* translators: 1: wp_enqueue_scripts, 2: admin_enqueue_scripts, 3: login_enqueue_scripts */
|
||||
__( 'Scripts and styles should not be registered or enqueued until the %1$s, %2$s, or %3$s hooks.' ),
|
||||
'<code>wp_enqueue_scripts</code>',
|
||||
'<code>admin_enqueue_scripts</code>',
|
||||
'<code>login_enqueue_scripts</code>'
|
||||
), '3.3.0'
|
||||
),
|
||||
'3.3.0'
|
||||
);
|
||||
}
|
||||
|
||||
@@ -111,12 +113,14 @@ function wp_add_inline_script( $handle, $data, $position = 'after' ) {
|
||||
|
||||
if ( false !== stripos( $data, '</script>' ) ) {
|
||||
_doing_it_wrong(
|
||||
__FUNCTION__, sprintf(
|
||||
__FUNCTION__,
|
||||
sprintf(
|
||||
/* translators: 1: <script>, 2: wp_add_inline_script() */
|
||||
__( 'Do not pass %1$s tags to %2$s.' ),
|
||||
'<code><script></code>',
|
||||
'<code>wp_add_inline_script()</code>'
|
||||
), '4.5.0'
|
||||
),
|
||||
'4.5.0'
|
||||
);
|
||||
$data = trim( preg_replace( '#<script[^>]*>(.*)</script>#is', '$1', $data ) );
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user