vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coding Standards: Upgrade WPCS to 1.0.0

Browse Source 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.



git-svn-id: https://develop.svn.wordpress.org/trunk@43571 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast
2018-08-17 01:50:26 +00:00
parent fed48ba3fe
commit a75d153eee
549 changed files with 9936 additions and 6721 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
tests/phpunit/tests/customize/partial.php
View File

@@ -116,7 +116,9 @@ class Test_WP_Customize_Partial extends WP_UnitTestCase {
$this->assertContains( 'Lorem Ipsum', $partial->render() );
$partial = new WP_Customize_Partial(
$this->selective_refresh, $partial_id, array(
$this->selective_refresh,
$partial_id,
array(
'settings' => 'blogdescription',
)
);
@@ -221,7 +223,9 @@ class Test_WP_Customize_Partial extends WP_UnitTestCase {
*/
function test_render_with_bad_callback_should_give_preference_to_return_value() {
$partial = new WP_Customize_Partial(
$this->selective_refresh, 'foo', array(
$this->selective_refresh,
'foo',
array(
'render_callback' => array( $this, 'render_echo_and_return' ),
)
);
@@ -236,7 +240,9 @@ class Test_WP_Customize_Partial extends WP_UnitTestCase {
*/
function test_render_echo_callback() {
$partial = new WP_Customize_Partial(
$this->selective_refresh, 'foo', array(
$this->selective_refresh,
'foo',
array(
'render_callback' => array( $this, 'render_echo' ),
)
);
@@ -257,7 +263,9 @@ class Test_WP_Customize_Partial extends WP_UnitTestCase {
*/
function test_render_return_callback() {
$partial = new WP_Customize_Partial(
$this->selective_refresh, 'foo', array(
$this->selective_refresh,
'foo',
array(
'render_callback' => array( $this, 'render_return' ),
)
);
@@ -319,40 +327,51 @@ class Test_WP_Customize_Partial extends WP_UnitTestCase {
wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
do_action( 'customize_register', $this->wp_customize );
$partial = new WP_Customize_Partial(
$this->selective_refresh, 'blogname', array(
$this->selective_refresh,
'blogname',
array(
'settings' => array( 'blogname' ),
)
);
$this->assertTrue( $partial->check_capabilities() );
$partial = new WP_Customize_Partial(
$this->selective_refresh, 'blogname', array(
$this->selective_refresh,
'blogname',
array(
'settings' => array( 'blogname', 'non_existing' ),
)
);
$this->assertFalse( $partial->check_capabilities() );
$this->wp_customize->add_setting(
'top_secret_message', array(
'top_secret_message',
array(
'capability' => 'top_secret_clearance',
)
);
$partial = new WP_Customize_Partial(
$this->selective_refresh, 'blogname', array(
$this->selective_refresh,
'blogname',
array(
'settings' => array( 'blogname', 'top_secret_clearance' ),
)
);
$this->assertFalse( $partial->check_capabilities() );
$partial = new WP_Customize_Partial(
$this->selective_refresh, 'no_setting', array(
$this->selective_refresh,
'no_setting',
array(
'settings' => array(),
)
);
$this->assertTrue( $partial->check_capabilities() );
$partial = new WP_Customize_Partial(
$this->selective_refresh, 'no_setting', array(
$this->selective_refresh,
'no_setting',
array(
'settings' => array(),
'capability' => 'top_secret_clearance',
)
@@ -360,7 +379,9 @@ class Test_WP_Customize_Partial extends WP_UnitTestCase {
$this->assertFalse( $partial->check_capabilities() );
$partial = new WP_Customize_Partial(
$this->selective_refresh, 'no_setting', array(
$this->selective_refresh,
'no_setting',
array(
'settings' => array(),
'capability' => 'edit_theme_options',
)