vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-28 13:00:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coding Standards: Upgrade WPCS to 1.0.0

Browse Source 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.



git-svn-id: https://develop.svn.wordpress.org/trunk@43571 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast
2018-08-17 01:50:26 +00:00
parent fed48ba3fe
commit a75d153eee
549 changed files with 9936 additions and 6721 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/phpunit/tests/customize/setting.php
View File

@@ -444,7 +444,8 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
// Custom type that does not handle supplying the post value from the customize_value_{$id_base} filter.
$setting_id = 'custom_without_previewing_value_filter';
$setting = $this->manager->add_setting(
$setting_id, array(
$setting_id,
array(
'type' => 'custom_preview_test',
'default' => 123,
'sanitize_callback' => array( $this->manager->nav_menus, 'intval_base10' ),
@@ -599,7 +600,9 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
$name = 'autoloaded1';
$setting = new WP_Customize_Setting(
$this->manager, $name, array(
$this->manager,
$name,
array(
'type' => 'option',
)
);
@@ -612,7 +615,9 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
$name = 'autoloaded2';
$setting = new WP_Customize_Setting(
$this->manager, $name, array(
$this->manager,
$name,
array(
'type' => 'option',
'autoload' => true,
)
@@ -626,7 +631,9 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
$name = 'not-autoloaded1';
$setting = new WP_Customize_Setting(
$this->manager, $name, array(
$this->manager,
$name,
array(
'type' => 'option',
'autoload' => false,
)
@@ -640,12 +647,16 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
$id_base = 'multi-not-autoloaded';
$setting1 = new WP_Customize_Setting(
$this->manager, $id_base . '[foo]', array(
$this->manager,
$id_base . '[foo]',
array(
'type' => 'option',
)
);
$setting2 = new WP_Customize_Setting(
$this->manager, $id_base . '[bar]', array(
$this->manager,
$id_base . '[bar]',
array(
'type' => 'option',
'autoload' => false,
)
@@ -695,7 +706,9 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
*/
public function test_validate() {
$setting = new WP_Customize_Setting(
$this->manager, 'name', array(
$this->manager,
'name',
array(
'type' => 'key',
'validate_callback' => array( $this, 'filter_validate_for_test_validate' ),
)
@@ -735,7 +748,8 @@ class Tests_WP_Customize_Setting extends WP_UnitTestCase {
$initial_value = 456;
set_theme_mod(
'nav_menu_locations', array(
'nav_menu_locations',
array(
'primary' => $initial_value,
)
);