mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2026-05-29 15:44:27 +00:00
Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues. This change includes three notable additions: - Multiline function calls must now put each parameter on a new line. - Auto-formatting files is now part of the `grunt precommit` script. - Auto-fixable coding standards issues will now cause Travis failures. Fixes #44600. git-svn-id: https://develop.svn.wordpress.org/trunk@43571 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
@@ -14,7 +14,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
'_baba' => 5,
|
||||
'yZ' => 'baba',
|
||||
'a' => array( 5, 111, 'x' ),
|
||||
), wp_parse_args( $x )
|
||||
),
|
||||
wp_parse_args( $x )
|
||||
);
|
||||
$y = new MockClass;
|
||||
$this->assertEquals( array(), wp_parse_args( $y ) );
|
||||
@@ -34,7 +35,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
'_baba' => 5,
|
||||
'yZ' => 'baba',
|
||||
'a' => array( 5, 111, 'x' ),
|
||||
), wp_parse_args( $b )
|
||||
),
|
||||
wp_parse_args( $b )
|
||||
);
|
||||
}
|
||||
|
||||
@@ -50,7 +52,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
'_baba' => 5,
|
||||
'yZ' => 'baba',
|
||||
'a' => array( 5, 111, 'x' ),
|
||||
), wp_parse_args( $x, $d )
|
||||
),
|
||||
wp_parse_args( $x, $d )
|
||||
);
|
||||
$e = array( '_baba' => 6 );
|
||||
$this->assertEquals(
|
||||
@@ -58,7 +61,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
'_baba' => 5,
|
||||
'yZ' => 'baba',
|
||||
'a' => array( 5, 111, 'x' ),
|
||||
), wp_parse_args( $x, $e )
|
||||
),
|
||||
wp_parse_args( $x, $e )
|
||||
);
|
||||
}
|
||||
|
||||
@@ -299,19 +303,23 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
$this->assertEquals( "$url?foo=1", add_query_arg( 'foo', '1', $url ) );
|
||||
$this->assertEquals( "$url?foo=1", add_query_arg( array( 'foo' => '1' ), $url ) );
|
||||
$this->assertEquals(
|
||||
"$url?foo=2", add_query_arg(
|
||||
"$url?foo=2",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'foo' => '2',
|
||||
), $url
|
||||
),
|
||||
$url
|
||||
)
|
||||
);
|
||||
$this->assertEquals(
|
||||
"$url?foo=1&bar=2", add_query_arg(
|
||||
"$url?foo=1&bar=2",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'bar' => '2',
|
||||
), $url
|
||||
),
|
||||
$url
|
||||
)
|
||||
);
|
||||
|
||||
@@ -320,7 +328,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
$this->assertEquals( "$url?foo=1", add_query_arg( 'foo', '1' ) );
|
||||
$this->assertEquals( "$url?foo=1", add_query_arg( array( 'foo' => '1' ) ) );
|
||||
$this->assertEquals(
|
||||
"$url?foo=2", add_query_arg(
|
||||
"$url?foo=2",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'foo' => '2',
|
||||
@@ -328,7 +337,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
)
|
||||
);
|
||||
$this->assertEquals(
|
||||
"$url?foo=1&bar=2", add_query_arg(
|
||||
"$url?foo=1&bar=2",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'bar' => '2',
|
||||
@@ -344,19 +354,23 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
$this->assertEquals( "$url?foo=1#frag", add_query_arg( 'foo', '1', $frag_url ) );
|
||||
$this->assertEquals( "$url?foo=1#frag", add_query_arg( array( 'foo' => '1' ), $frag_url ) );
|
||||
$this->assertEquals(
|
||||
"$url?foo=2#frag", add_query_arg(
|
||||
"$url?foo=2#frag",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'foo' => '2',
|
||||
), $frag_url
|
||||
),
|
||||
$frag_url
|
||||
)
|
||||
);
|
||||
$this->assertEquals(
|
||||
"$url?foo=1&bar=2#frag", add_query_arg(
|
||||
"$url?foo=1&bar=2#frag",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'bar' => '2',
|
||||
), $frag_url
|
||||
),
|
||||
$frag_url
|
||||
)
|
||||
);
|
||||
|
||||
@@ -365,7 +379,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
$this->assertEquals( "$url?foo=1#frag", add_query_arg( 'foo', '1' ) );
|
||||
$this->assertEquals( "$url?foo=1#frag", add_query_arg( array( 'foo' => '1' ) ) );
|
||||
$this->assertEquals(
|
||||
"$url?foo=2#frag", add_query_arg(
|
||||
"$url?foo=2#frag",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'foo' => '2',
|
||||
@@ -373,7 +388,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
)
|
||||
);
|
||||
$this->assertEquals(
|
||||
"$url?foo=1&bar=2#frag", add_query_arg(
|
||||
"$url?foo=1&bar=2#frag",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'bar' => '2',
|
||||
@@ -400,19 +416,23 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
$this->assertEquals( "$url&foo=1", add_query_arg( 'foo', '1', $url ) );
|
||||
$this->assertEquals( "$url&foo=1", add_query_arg( array( 'foo' => '1' ), $url ) );
|
||||
$this->assertEquals(
|
||||
"$url&foo=2", add_query_arg(
|
||||
"$url&foo=2",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'foo' => '2',
|
||||
), $url
|
||||
),
|
||||
$url
|
||||
)
|
||||
);
|
||||
$this->assertEquals(
|
||||
"$url&foo=1&bar=2", add_query_arg(
|
||||
"$url&foo=1&bar=2",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'bar' => '2',
|
||||
), $url
|
||||
),
|
||||
$url
|
||||
)
|
||||
);
|
||||
|
||||
@@ -421,7 +441,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
$this->assertEquals( "$url&foo=1", add_query_arg( 'foo', '1' ) );
|
||||
$this->assertEquals( "$url&foo=1", add_query_arg( array( 'foo' => '1' ) ) );
|
||||
$this->assertEquals(
|
||||
"$url&foo=2", add_query_arg(
|
||||
"$url&foo=2",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'foo' => '2',
|
||||
@@ -429,7 +450,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
)
|
||||
);
|
||||
$this->assertEquals(
|
||||
"$url&foo=1&bar=2", add_query_arg(
|
||||
"$url&foo=1&bar=2",
|
||||
add_query_arg(
|
||||
array(
|
||||
'foo' => '1',
|
||||
'bar' => '2',
|
||||
@@ -452,7 +474,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
array(
|
||||
'foo' => 'bar',
|
||||
'1' => '2',
|
||||
), '1=1'
|
||||
),
|
||||
'1=1'
|
||||
);
|
||||
$this->assertEquals( '1=2&foo=bar', $url );
|
||||
|
||||
@@ -1270,7 +1293,8 @@ class Tests_Functions extends WP_UnitTestCase {
|
||||
// Test a few additional file types on single sites.
|
||||
if ( ! is_multisite() ) {
|
||||
$data = array_merge(
|
||||
$data, array(
|
||||
$data,
|
||||
array(
|
||||
// Standard non-image file.
|
||||
array(
|
||||
DIR_TESTDATA . '/formatting/big5.txt',
|
||||
|
||||
Reference in New Issue
Block a user