vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-14 05:40:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coding Standards: Upgrade WPCS to 1.0.0

Browse Source 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.



git-svn-id: https://develop.svn.wordpress.org/trunk@43571 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast
2018-08-17 01:50:26 +00:00
parent fed48ba3fe
commit a75d153eee
549 changed files with 9936 additions and 6721 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/image/functions.php
+43 -9
View File
@@ -308,7 +308,12 @@ class Tests_Image_Functions extends WP_UnitTestCase {
$file = wp_crop_image(
DIR_TESTDATA . '/images/canola.jpg',
0, 0, 100, 100, 100, 100
0,
0,
100,
100,
100,
100
);
$this->assertNotWPError( $file );
$this->assertFileExists( $file );
@@ -331,7 +336,13 @@ class Tests_Image_Functions extends WP_UnitTestCase {
$file = wp_crop_image(
'https://asdftestblog1.files.wordpress.com/2008/04/canola.jpg',
0, 0, 100, 100, 100, 100, false,
0,
0,
100,
100,
100,
100,
false,
DIR_TESTDATA . '/images/' . __FUNCTION__ . '.jpg'
);
$this->assertNotWPError( $file );
@@ -347,7 +358,12 @@ class Tests_Image_Functions extends WP_UnitTestCase {
public function test_wp_crop_image_file_not_exist() {
$file = wp_crop_image(
DIR_TESTDATA . '/images/canoladoesnotexist.jpg',
0, 0, 100, 100, 100, 100
0,
0,
100,
100,
100,
100
);
$this->assertInstanceOf( 'WP_Error', $file );
}
@@ -359,7 +375,12 @@ class Tests_Image_Functions extends WP_UnitTestCase {
$file = wp_crop_image(
'https://asdftestblog1.files.wordpress.com/2008/04/canoladoesnotexist.jpg',
0, 0, 100, 100, 100, 100
0,
0,
100,
100,
100,
100
);
$this->assertInstanceOf( 'WP_Error', $file );
}
@@ -377,7 +398,12 @@ class Tests_Image_Functions extends WP_UnitTestCase {
$file = wp_crop_image(
DIR_TESTDATA . '/images/canola.jpg',
0, 0, 100, 100, 100, 100
0,
0,
100,
100,
100,
100
);
$this->assertInstanceOf( 'WP_Error', $file );
@@ -398,7 +424,9 @@ class Tests_Image_Functions extends WP_UnitTestCase {
copy( $orig_file, $test_file );
$attachment_id = $this->factory->attachment->create_object(
$test_file, 0, array(
$test_file,
0,
array(
'post_mime_type' => 'application/pdf',
)
);
@@ -461,7 +489,9 @@ class Tests_Image_Functions extends WP_UnitTestCase {
copy( $orig_file, $test_file );
$attachment_id = $this->factory->attachment->create_object(
$test_file, 0, array(
$test_file,
0,
array(
'post_mime_type' => 'application/pdf',
)
);
@@ -519,7 +549,9 @@ class Tests_Image_Functions extends WP_UnitTestCase {
copy( $orig_file, $test_file );
$attachment_id = $this->factory->attachment->create_object(
$test_file, 0, array(
$test_file,
0,
array(
'post_mime_type' => 'application/pdf',
)
);
@@ -577,7 +609,9 @@ class Tests_Image_Functions extends WP_UnitTestCase {
copy( DIR_TESTDATA . '/images/wordpress-gsoc-flyer.pdf', $pdf_path );
$attachment_id = $this->factory->attachment->create_object(
$pdf_path, 0, array(
$pdf_path,
0,
array(
'post_mime_type' => 'application/pdf',
)
);