From adff7dfb8e5f477f0877870fea5ed40439bbae68 Mon Sep 17 00:00:00 2001
From: Scott Taylor <wonderboymusic@git.wordpress.org>
Date: Thu, 7 Aug 2014 05:19:14 +0000
Subject: [PATCH] Media Grid: add screen reader labels with more context to
 filters and bulk actions. Ditto for list view.

Props afercia.
Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29428 602fd350-edb4-49c9-b593-d223f7449a82
---
 src/wp-admin/includes/class-wp-list-table.php |  5 ++-
 src/wp-includes/js/media-grid.js              |  3 +-
 src/wp-includes/js/media-views.js             | 41 ++++++++++++-------
 src/wp-includes/media.php                     |  4 ++
 4 files changed, 36 insertions(+), 17 deletions(-)

diff --git a/src/wp-admin/includes/class-wp-list-table.php b/src/wp-admin/includes/class-wp-list-table.php
index 190b20536a..b23da4cee8 100644
--- a/src/wp-admin/includes/class-wp-list-table.php
+++ b/src/wp-admin/includes/class-wp-list-table.php
@@ -371,7 +371,7 @@ class WP_List_Table {
 		if ( empty( $this->_actions ) )
 			return;
 
-		echo "<label for='bulk-action-selector-" . esc_attr( $which ) . "' class='screen-reader-text'>" . __( 'Select Bulk Action' ) . "</label>";
+		echo "<label for='bulk-action-selector-" . esc_attr( $which ) . "' class='screen-reader-text'>" . __( 'Select bulk action' ) . "</label>";
 		echo "<select name='action$two' id='bulk-action-selector-" . esc_attr( $which ) . "'>\n";
 		echo "<option value='-1' selected='selected'>" . __( 'Bulk Actions' ) . "</option>\n";
 
@@ -469,7 +469,8 @@ class WP_List_Table {
 
 		$m = isset( $_GET['m'] ) ? (int) $_GET['m'] : 0;
 ?>
-		<select name="m">
+		<label for="filter-by-date" class="screen-reader-text"><?php _e( 'Filter by date' ); ?></label>
+		<select name="m" id="filter-by-date">
 			<option<?php selected( $m, 0 ); ?> value="0"><?php _e( 'All dates' ); ?></option>
 <?php
 		foreach ( $months as $arc_row ) {
diff --git a/src/wp-includes/js/media-grid.js b/src/wp-includes/js/media-grid.js
index 9491e8d6cb..861b115b91 100644
--- a/src/wp-includes/js/media-grid.js
+++ b/src/wp-includes/js/media-grid.js
@@ -565,7 +565,8 @@
 	 * @augments Backbone.View
 	 */
 	media.view.BulkSelectionActionDropdown = media.View.extend({
-		tagName:   'select',
+		tagName: 'select',
+		id:      'bulk-select-dropdown',
 
 		initialize: function() {
 			media.view.Button.prototype.initialize.apply( this, arguments );
diff --git a/src/wp-includes/js/media-views.js b/src/wp-includes/js/media-views.js
index 7b767c609f..4d559bee6a 100644
--- a/src/wp-includes/js/media-views.js
+++ b/src/wp-includes/js/media-views.js
@@ -5697,7 +5697,10 @@
 			var filters,
 				LibraryViewSwitcher,
 				FiltersConstructor,
-				screenReaderText;
+				filterByTypeLabel,
+				bulkActionsLabel,
+				filterByDateLabel,
+				searchLabel;
 
 			/**
 			 * @member {wp.media.view.Toolbar}
@@ -5712,24 +5715,32 @@
 			// browser view. Is this a use case for doAction( 'add:toolbar-items:attachments-browser', this.toolbar );
 			// which the controller can tap into and add this view?
 			if ( this.controller.activeModes.where( { id: 'grid' } ).length ) {
+
 				LibraryViewSwitcher = media.View.extend({
 					className: 'view-switch media-grid-view-switch',
 					template: media.template( 'media-library-view-switcher')
 				});
+
 				this.toolbar.set( 'libraryViewSwitcher', new LibraryViewSwitcher({
 					controller: this.controller,
 					priority: -90
 				}).render() );
 
+				this.toolbar.set( 'dateFilter', new media.view.DateFilter({
+					controller: this.controller,
+					model:      this.collection.props,
+					priority: -75
+				}).render() );
+
 				this.toolbar.set( 'bulkSelection', new media.view.BulkSelection({
 					controller: this.controller,
 					priority: -70
 				}).render() );
-				this.toolbar.set( 'dateFilter', new media.view.DateFilter({
-					controller: this.controller,
-					model:      this.collection.props,
-					priority: -75
-				}).render() );
+
+				this.toolbar.set( 'spinner', new media.view.Spinner({
+					priority: -60
+				}) );
+
 			}
 
 			filters = this.options.filters;
@@ -5746,13 +5757,15 @@
 					priority:   -80
 				}).render() );
 
-				screenReaderText = $( '<label class="screen-reader-text" for="media-attachment-filters">' + l10n.select + '</label>' );
-				this.toolbar.get( 'filters' ).$el.before( screenReaderText );
-			}
+				filterByTypeLabel = $( '<label class="screen-reader-text" for="media-attachment-filters">' + l10n.filterByType + '</label>' );
+				this.toolbar.get( 'filters' ).$el.before( filterByTypeLabel );
 
-			this.toolbar.set( 'spinner', new media.view.Spinner({
-				priority: -70
-			}) );
+				filterByDateLabel = $( '<label class="screen-reader-text" for="media-attachment-date-filters">' + l10n.filterByDate + '</label>' );
+				this.toolbar.get( 'dateFilter' ).$el.before( filterByDateLabel );
+
+				bulkActionsLabel = $( '<label class="screen-reader-text" for="bulk-select-dropdown">' + l10n.bulkActionsLabel + '</label>' );
+				this.toolbar.get( 'bulkSelection' ).$el.before( bulkActionsLabel );
+			}
 
 			if ( this.options.search ) {
 				this.toolbar.set( 'search', new media.view.Search({
@@ -5760,8 +5773,8 @@
 					model:      this.collection.props,
 					priority:   60
 				}).render() );
-				screenReaderText = $( '<label class="screen-reader-text" for="media-search-input">' + l10n.search + '</label>' );
-				this.toolbar.get( 'search' ).$el.before( screenReaderText );
+				searchLabel = $( '<label class="screen-reader-text" for="media-search-input">' + l10n.searchMediaLabel + '</label>' );
+				this.toolbar.get( 'search' ).$el.before( searchLabel );
 			}
 
 			if ( this.options.dragInfo ) {
diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php
index d081889de0..eb5cf2c10e 100644
--- a/src/wp-includes/media.php
+++ b/src/wp-includes/media.php
@@ -2928,8 +2928,12 @@ function wp_enqueue_media( $args = array() ) {
 		'warnDelete'             => __( "You are about to permanently delete this item.\n  'Cancel' to stop, 'OK' to delete." ),
 		'warnBulkDelete'         => __( "You are about to permanently delete these items.\n  'Cancel' to stop, 'OK' to delete." ),
 		'bulkActions'            => __( 'Bulk Actions' ),
+		'bulkActionsLabel'       => __( 'Select bulk action' ),
 		'deletePermanently'      => __( 'Delete Permanently' ),
 		'apply'                  => __( 'Apply' ),
+		'filterByDate'           => __( 'Filter by date' ),
+		'filterByType'           => __( 'Filter by type' ),
+		'searchMediaLabel'       => __( 'Search Media' ),
 
 		// Library Details
 		'attachmentDetails'  => __( 'Attachment Details' ),