vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 20:30:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Plugins: Move capability checks further up in wp_ajax_update_plugin() and wp_ajax_delete_plugin().

Browse Source 
Add tests for both Ajax handlers.

Props Yorick Koster, swissspidy.
Fixes #37490.

git-svn-id: https://develop.svn.wordpress.org/trunk@38168 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Dominik Schilling
2016-07-27 17:42:01 +00:00
parent d097c1d916
commit af6b1a5388
5 changed files with 376 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/ajax/DeletePlugin.php
+158
View File
@@ -0,0 +1,158 @@
<?php
/**
* Admin ajax functions to be tested
*/
require_once( ABSPATH . 'wp-admin/includes/ajax-actions.php' );
/**
* Testing Ajax handler for deleting a plugin.
*
* @group ajax
*/
class Tests_Ajax_Delete_Plugin extends WP_Ajax_UnitTestCase {
/**
* @expectedException WPAjaxDieStopException
* @expectedExceptionMessage -1
*/
public function test_missing_nonce() {
$this->_handleAjax( 'delete-plugin' );
}
public function test_missing_plugin() {
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['slug'] = 'foo';
// Make the request
try {
$this->_handleAjax( 'delete-plugin' );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => false,
'data' => array(
'slug' => '',
'errorCode' => 'no_plugin_specified',
'errorMessage' => 'No plugin specified.',
),
);
$this->assertEqualSets( $expected, $response );
}
public function test_missing_slug() {
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['plugin'] = 'foo/bar.php';
// Make the request
try {
$this->_handleAjax( 'delete-plugin' );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => false,
'data' => array(
'slug' => '',
'errorCode' => 'no_plugin_specified',
'errorMessage' => 'No plugin specified.',
),
);
$this->assertEqualSets( $expected, $response );
}
public function test_missing_capability() {
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['plugin'] = 'foo/bar.php';
$_POST['slug'] = 'foo';
// Make the request
try {
$this->_handleAjax( 'delete-plugin' );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => false,
'data' => array(
'delete' => 'plugin',
'slug' => 'foo',
'errorMessage' => 'Sorry, you are not allowed to delete plugins for this site.',
),
);
$this->assertEqualSets( $expected, $response );
}
public function test_invalid_file() {
$this->_setRole( 'administrator' );
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['plugin'] = '../foo/bar.php';
$_POST['slug'] = 'foo';
// Make the request
try {
$this->_handleAjax( 'delete-plugin' );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => false,
'data' => array(
'delete' => 'plugin',
'slug' => 'foo',
'errorMessage' => 'Sorry, you are not allowed to delete plugins for this site.',
),
);
$this->assertEqualSets( $expected, $response );
}
public function test_delete_plugin() {
$this->_setRole( 'administrator' );
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['plugin'] = 'foo.php';
$_POST['slug'] = 'foo';
// Make the request
try {
$this->_handleAjax( 'delete-plugin' );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => true,
'data' => array(
'delete' => 'plugin',
'slug' => 'foo',
'plugin' => 'foo.php',
'pluginName' => '',
),
);
$this->assertEqualSets( $expected, $response );
}
}
tests/phpunit/tests/ajax/UpdatePlugin.php
+169
View File
@@ -0,0 +1,169 @@
<?php
/**
* Admin ajax functions to be tested
*/
require_once( ABSPATH . 'wp-admin/includes/ajax-actions.php' );
/**
* Testing Ajax handler for updating a plugin.
*
* @group ajax
*/
class Tests_Ajax_Update_Plugin extends WP_Ajax_UnitTestCase {
/**
* @expectedException WPAjaxDieStopException
* @expectedExceptionMessage -1
*/
public function test_missing_nonce() {
$this->_handleAjax( 'update-plugin' );
}
public function test_missing_plugin() {
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['slug'] = 'foo';
// Make the request
try {
$this->_handleAjax( 'update-plugin' );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => false,
'data' => array(
'slug' => '',
'errorCode' => 'no_plugin_specified',
'errorMessage' => 'No plugin specified.',
),
);
$this->assertEqualSets( $expected, $response );
}
public function test_missing_slug() {
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['plugin'] = 'foo/bar.php';
// Make the request
try {
$this->_handleAjax( 'update-plugin' );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => false,
'data' => array(
'slug' => '',
'errorCode' => 'no_plugin_specified',
'errorMessage' => 'No plugin specified.',
),
);
$this->assertEqualSets( $expected, $response );
}
public function test_missing_capability() {
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['plugin'] = 'foo/bar.php';
$_POST['slug'] = 'foo';
// Make the request
try {
$this->_handleAjax( 'update-plugin' );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => false,
'data' => array(
'update' => 'plugin',
'slug' => 'foo',
'errorMessage' => 'Sorry, you are not allowed to update plugins for this site.',
'oldVersion' => '',
'newVersion' => '',
),
);
$this->assertEqualSets( $expected, $response );
}
public function test_invalid_file() {
$this->_setRole( 'administrator' );
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['plugin'] = '../foo/bar.php';
$_POST['slug'] = 'foo';
// Make the request
try {
$this->_handleAjax( 'update-plugin' );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => false,
'data' => array(
'update' => 'plugin',
'slug' => 'foo',
'errorMessage' => 'Sorry, you are not allowed to update plugins for this site.',
'oldVersion' => '',
'newVersion' => '',
),
);
$this->assertEqualSets( $expected, $response );
}
public function test_update_plugin() {
$this->_setRole( 'administrator' );
$_POST['_ajax_nonce'] = wp_create_nonce( 'updates' );
$_POST['plugin'] = 'hello.php';
$_POST['slug'] = 'hello-dolly';
// Make the request
try {
// Prevent wp_update_plugins() from running
wp_installing( true );
$this->_handleAjax( 'update-plugin' );
wp_installing( false );
} catch ( WPAjaxDieContinueException $e ) {
unset( $e );
}
// Get the response.
$response = json_decode( $this->_last_response, true );
$expected = array(
'success' => false,
'data' => array(
'update' => 'plugin',
'slug' => 'hello-dolly',
'plugin' => 'hello.php',
'pluginName' => 'Hello Dolly',
'errorMessage' => 'Plugin update failed.',
'oldVersion' => 'Version 1.6',
'newVersion' => '',
'debug' => array( 'The plugin is at the latest version.' ),
),
);
$this->assertEqualSets( $expected, $response );
}
}